Add RGB gesture recognition #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katerynaCh
added
test sources
katerynaCh
requested review from
passalis,
omichel,
ad-daniel and
stefaniapedrazzi
as code owners
Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>
Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>
…e_recognition.py Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>
…nition_node.py Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>
Thank you! I have incorporated the changes. |
|
Hey @katerynaCh, thank you for the new tool. I will do a thorough review soon. Taking a quick look, i noticed that doc entries for the ROS1/2 nodes seem to be missing. In the meantime, could you please add entries in the index lists here (ros1) and here (ros2) that link to corresponding sections here and here? Let me know if you have any issues i can assist with! |
tsampazk
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Thank you @katerynaCh! I went ahead and applied various minor fixes that i will list below.
- Tool webcam demo works really well, just fixed the max-hands argument type that was passed as a str and threw an error when trying to change it via command line
- Added some checks in the learner download method so the model doesn't get redownloaded if it already exists
- Renamed the demo to webcam_demo to match most common naming in other tools
- ROS1 node worked out of the box, just renamed the topics to match naming in other nodes (modified the doc appropriately too)
- ROS2 node had an issue in the bridge conversion and threw an error which i fixed with a try/except because i am almost certain that if i straight up applied the float conversion, other ROS nodes will break, so that takes care of it.
- Similar to ROS1 i modified the topic names to match other nodes (in the doc too) and changed the run command to the correct one (also noticed that some other tools had the same issue in the run command and fixed it).
All-in-all everything else looks good to me, thanks!
|
Thank you @tsampazk @stefaniapedrazzi ! |
lucamarchionni
pushed a commit
to lucamarchionni/opendr
that referenced
this pull request
Jun 10, 2024
* init commit * uncomment debug * demo fixes * demo fixes * ros2 node * learner update * added test * added docs and dependencies * update demo readme * added readme * minor learner fix * linter fixes * linter fixes * linter fixes * license fix * demo fix * docs fix * Add test to tests_suite.yml * Add test to tests_suite_develop.yml * Add test to test_packages.yml * Update docs/reference/gesture-recognition-learner.md Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com> * Update docs/reference/gesture-recognition-learner.md Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com> * Update docs/reference/index.md Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com> * Update projects/python/perception/gesture_recognition/README.md Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com> * Update tests/sources/tools/perception/gesture_recognition/test_gesture_recognition.py Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com> * Update projects/opendr_ws/src/opendr_perception/scripts/gesture_recognition_node.py Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com> * added performance profiling to ROS1 node * style fix * Fixed argument type * Already exists check before re-downloading * Renamed demo to webcam_demo * Renamed demo to webcam_demo in readme * added ROS/ROS2 node documentation and changed output topic names * ROS2 README fix * Added backwards compatible float conversion in ROS2 bridge to_ros_boxes * Some minor fixes in ROS1 gesture topic names * Some minor fixes in ROS1 gesture topic names and learner link in doc * Some minor fixes in ROS2 gesture topic names * Some minor fixes in ROS2 gesture learner link, run command, topic names in doc --------- Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com> Co-authored-by: tsampazk <27914645+tsampazk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements RGB-based hands gesture recognition (detection) based on hagrid dataset for 18 hand gestures.
We currently provide one pretrained model. ROS1/ROS2 nodes are included, as well as a webcam demo.
Algorithmically it relies on existing implementation of nanodet (I thought it is better from application perspective to create a dedicated learner for gesture recognition, but please let me know if you think otherwise and I change it, and just provide necessary model/dataset processing/configs as part of nanodet learner).