Fix ROS1 nodes argparse issue with .launch files #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es from launch files
omichel
approved these changes
Sep 22, 2023
tsampazk
added a commit
that referenced
this pull request
Sep 25, 2023
Merged
tsampazk
added a commit
that referenced
this pull request
Sep 25, 2023
* init commit * update readme * update readme * fix ros node readme * fix ros node readmes * style fixes * style fixes * style fixes * style * fix ros node data type * ros data type fix * fixed unused import * license fix * style fix * style fix * license fix * change the way text backbone is defined in demos and ros nodes * change file path * added missing import * ditto * fixed download paths in python demos * style fix * style fix * fixed ros nodes to be consistent with last changes in speech transcription * bug fix in ros node * bug fix * removed unused function * Added __init__.py to intent recognition test * Update src/opendr/perception/multimodal_human_centric/intent_recognition_learner/intent_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/multimodal_human_centric/intent_recognition_learner/intent_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/python/perception/multimodal_human_centric/intent_recognition/README.MD Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/multimodal_human_centric/intent_recognition_learner/intent_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/multimodal_human_centric/intent_recognition_learner/intent_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update docs/reference/intent-recognition-learner.md Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/multimodal_human_centric/intent_recognition_learner/intent_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/multimodal_human_centric/intent_recognition_learner/intent_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/multimodal_human_centric/intent_recognition_learner/intent_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/multimodal_human_centric/intent_recognition_learner/intent_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/multimodal_human_centric/intent_recognition_learner/intent_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/multimodal_human_centric/intent_recognition_learner/intent_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * updated nltk download path; unittest dataset length; docs; order of methods in learner * fix error in test * fix pandas version-related bug * test * test * Added intent recognition dependency on hri msgs and added node to catkin_install_python * Added intent recognition in ros2 setup.py * Update projects/python/perception/multimodal_human_centric/intent_recognition/demo_speech.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/python/perception/multimodal_human_centric/intent_recognition/demo_speech.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/python/perception/multimodal_human_centric/intent_recognition/demo_speech.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/python/perception/multimodal_human_centric/intent_recognition/demo_speech.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/python/perception/multimodal_human_centric/intent_recognition/demo_speech.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/opendr_ws/src/opendr_perception/README.md Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/opendr_ws_2/src/opendr_perception/opendr_perception/intent_recognition_node.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/opendr_ws_2/src/opendr_perception/opendr_perception/intent_recognition_node.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/opendr_ws_2/src/opendr_perception/opendr_perception/intent_recognition_node.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/opendr_ws_2/src/opendr_perception/opendr_perception/intent_recognition_node.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/opendr_ws_2/src/opendr_perception/README.md Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/opendr_ws_2/src/opendr_perception/README.md Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/opendr_ws/src/opendr_perception/scripts/intent_recognition_node.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/opendr_ws/src/opendr_perception/scripts/intent_recognition_node.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/opendr_ws_2/src/opendr_perception/opendr_perception/intent_recognition_node.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/opendr_ws_2/src/opendr_perception/opendr_perception/intent_recognition_node.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * test fix * Update src/opendr/perception/multimodal_human_centric/intent_recognition_learner/intent_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Added fix from #465 to new node --------- Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
lucamarchionni
pushed a commit
to lucamarchionni/opendr
that referenced
this pull request
Jun 10, 2024
lucamarchionni
pushed a commit
to lucamarchionni/opendr
that referenced
this pull request
Jun 10, 2024
* init commit * update readme * update readme * fix ros node readme * fix ros node readmes * style fixes * style fixes * style fixes * style * fix ros node data type * ros data type fix * fixed unused import * license fix * style fix * style fix * license fix * change the way text backbone is defined in demos and ros nodes * change file path * added missing import * ditto * fixed download paths in python demos * style fix * style fix * fixed ros nodes to be consistent with last changes in speech transcription * bug fix in ros node * bug fix * removed unused function * Added __init__.py to intent recognition test * Update src/opendr/perception/multimodal_human_centric/intent_recognition_learner/intent_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/multimodal_human_centric/intent_recognition_learner/intent_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/python/perception/multimodal_human_centric/intent_recognition/README.MD Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/multimodal_human_centric/intent_recognition_learner/intent_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/multimodal_human_centric/intent_recognition_learner/intent_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update docs/reference/intent-recognition-learner.md Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/multimodal_human_centric/intent_recognition_learner/intent_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/multimodal_human_centric/intent_recognition_learner/intent_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/multimodal_human_centric/intent_recognition_learner/intent_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/multimodal_human_centric/intent_recognition_learner/intent_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/multimodal_human_centric/intent_recognition_learner/intent_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/multimodal_human_centric/intent_recognition_learner/intent_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * updated nltk download path; unittest dataset length; docs; order of methods in learner * fix error in test * fix pandas version-related bug * test * test * Added intent recognition dependency on hri msgs and added node to catkin_install_python * Added intent recognition in ros2 setup.py * Update projects/python/perception/multimodal_human_centric/intent_recognition/demo_speech.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/python/perception/multimodal_human_centric/intent_recognition/demo_speech.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/python/perception/multimodal_human_centric/intent_recognition/demo_speech.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/python/perception/multimodal_human_centric/intent_recognition/demo_speech.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/python/perception/multimodal_human_centric/intent_recognition/demo_speech.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/opendr_ws/src/opendr_perception/README.md Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/opendr_ws_2/src/opendr_perception/opendr_perception/intent_recognition_node.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/opendr_ws_2/src/opendr_perception/opendr_perception/intent_recognition_node.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/opendr_ws_2/src/opendr_perception/opendr_perception/intent_recognition_node.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/opendr_ws_2/src/opendr_perception/opendr_perception/intent_recognition_node.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/opendr_ws_2/src/opendr_perception/README.md Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/opendr_ws_2/src/opendr_perception/README.md Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/opendr_ws/src/opendr_perception/scripts/intent_recognition_node.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/opendr_ws/src/opendr_perception/scripts/intent_recognition_node.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/opendr_ws_2/src/opendr_perception/opendr_perception/intent_recognition_node.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/opendr_ws_2/src/opendr_perception/opendr_perception/intent_recognition_node.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * test fix * Update src/opendr/perception/multimodal_human_centric/intent_recognition_learner/intent_recognition_learner.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Added fix from opendr-eu#465 to new node --------- Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #460.
See discussion in #460 for more details.
This PR applies the fix suggested by @thomaspeyrucain to all ROS1 nodes. The fix was tested and doesn't interfere with running the nodes normally.