-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fix on yolov5 webcam demo #466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Hmm it seems that our tests ignore |
…-yolov5-webcam-demo # Conflicts: # projects/python/perception/object_detection_2d/yolov5/webcam_demo.py
Do we really want to print this message to the console? I believe we could implement a more silent dummy usage, e.g., assign this version value to a dummy variable instead of printing it in the console. Also, it would be nice to add a comment here to explain why we need this dummy assignment. |
Yeah, i think that assigning and not using will still fail the pep8 tests for variable assigned but not used. On the other hand silencing print is too much trouble because one would need to manipulate stdout. I entirely removed print which didn't fail the pyflakes test locally (my IDE still complains), let's see if the CI is ok with it. |
It seems it passed the sources tests fine 😄. Sorry for the extra trouble Olivier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem. That's fine.
Good to see it passed the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
* Importing torch on yolov5 webcam demo to fix cuDNN error * Re-attempting noqa * Dummy usage of torch to avoid unused pep8 error * Removed print from dummy usage and added comment --------- Co-authored-by: Olivier Michel <Olivier.Michel@cyberbotics.com>
When running yolov5 webcam demo, i ran into this error:
when running
infer
.This is fixed by importing torch (even though it is not directly used) which seems to initialize it properly, similar to inference demo which works fine.
This issue seems to originate from the latest gpu installation of the toolkit as described in #463.