New utility feature class filtering for Object Detectors 2D #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katdimitris
added
enhancement
…nference demo for yolov5.
katdimitris
requested review from
passalis,
omichel and
stefaniapedrazzi
as code owners
tsampazk
requested changes
Sep 29, 2023
There was a problem hiding this comment.
Thank you @katdimitris, very nice job. I have added some comments. Mainly handling nanodet img/input is a bit problematic.
src/opendr/perception/object_detection_2d/utils/class_filter_wrapper.py
Outdated
Show resolved
Hide resolved
projects/python/perception/object_detection_2d/yolov5/filtered_inference_demo.py
Outdated
Show resolved
Hide resolved
projects/python/perception/object_detection_2d/yolov5/filtered_inference_demo.py
Outdated
Show resolved
Hide resolved
projects/python/perception/object_detection_2d/yolov5/filtered_inference_demo.py
Outdated
Show resolved
Hide resolved
projects/python/perception/object_detection_2d/yolov5/filtered_inference_demo.py
Outdated
Show resolved
Hide resolved
src/opendr/perception/object_detection_2d/utils/class_filter_wrapper.py
Outdated
Show resolved
Hide resolved
src/opendr/perception/object_detection_2d/utils/class_filter_wrapper.py
Outdated
Show resolved
Hide resolved
src/opendr/perception/object_detection_2d/utils/class_filter_wrapper.py
Outdated
Show resolved
Hide resolved
…rapper.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
…_inference_demo.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
…_inference_demo.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
…_inference_demo.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
…_inference_demo.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
…rapper.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
…rapper.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
tsampazk
approved these changes
Oct 2, 2023
lucamarchionni
pushed a commit
to lucamarchionni/opendr
that referenced
this pull request
Jun 10, 2024
…u#467) * Added initial version of class filtering * added parameter conditions for all implemented learners * added parameter conditions for all implemented learners * final implementation of class filtering for object detectors. added inference demo for yolov5. * correction inference demo for yolov5. * small fixes to pass tests * added License Copyright to pass test * Update src/opendr/perception/object_detection_2d/utils/class_filter_wrapper.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/python/perception/object_detection_2d/yolov5/filtered_inference_demo.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/python/perception/object_detection_2d/yolov5/filtered_inference_demo.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/python/perception/object_detection_2d/yolov5/filtered_inference_demo.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update projects/python/perception/object_detection_2d/yolov5/filtered_inference_demo.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/object_detection_2d/utils/class_filter_wrapper.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Update src/opendr/perception/object_detection_2d/utils/class_filter_wrapper.py Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com> * Removed filtering support for RetinaFace, since it exclusively detects face objects. --------- Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented class filtering for object detectors using a wrapper. The wrapper accepts a Learner object and a list of desired classes for detection. These classes should be within the set that the learner is capable of detecting. An inference demo for YOLOv5 is also available.
Closes #464.