Change bootstrapper for minikube-0.26 #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Why is this change necessary ? fixes: openebs/openebs#298 2. How does this change address the issue ? Trying to start kubelet inside travis in minikube-0.26 fails. minikube-0.26 makes use of kubeadm bootstrapper which tries to start systemctl-kubelet. Overriding with localkube bootstrapper(same as v0.25) solves the issue as of now. Also, the version of kubectl is changed to 1.8 to match vendor. 3. How to verify this change ? --bootstrapper=localkube flag is added while starting minikube. Signed-off-by: gkGaneshR <gkganesh126@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
=======================================
Coverage 28.48% 28.48%
=======================================
Files 59 59
Lines 4561 4561
=======================================
Hits 1299 1299
Misses 3113 3113
Partials 149 149Continue to review full report at Codecov.
|
prateekpandey14
approved these changes
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change necessary ?
fixes: Update vagrant launch steps to access UI openebs/openebs#298
How does this change address the issue ?
Trying to start kubelet inside travis in minikube-0.26 fails. minikube-0.26
makes use of kubeadm bootstrapper which tries to start systemctl-kubelet. Overriding
with localkube bootstrapper(same as v0.25) solves the issue as of now. Also,
the version of kubectl is changed to 1.8 to match vendor.
How to verify this change ?
--bootstrapper=localkube flag is added while starting minikube.
Signed-off-by: gkGaneshR gkganesh126@gmail.com
Special notes for your reviewer:
Ref: kubernetes/minikube#2704