chore(nexus_child/fault): add fault timestamp for nexus child #47
Conversation
Adds a timestamp when the child goes to faulted state. If child has never faulted, this will be blank. Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>
dsharma-dc
requested review from
dsavitskiy,
tiagolobocastro,
abhilashshetty04 and
Abhinandan-Purkait
| @@ -112,6 +112,7 @@ message Child { | |||
| ChildStateReason state_reason = 3; // child state reason | |||
| int32 rebuild_progress = 4; // rebuild progress | |||
| optional string device_name = 5; // child device name | |||
| google.protobuf.Timestamp fault_timestamp = 6; // timestamp(UTC) when child went faulted | |||
There was a problem hiding this comment.
Should it not be optional as we saw in confluence?
There was a problem hiding this comment.
Yes, it is an Option in the data-plane code. Here in the API, the autogenerated code corresponding to this is an Option as well. I'm not sure if we need optional keyword in protobuf file.
pub fault_timestamp: ::core::option::Option<::prost_wkt_types::Timestamp>
There was a problem hiding this comment.
I tried putting optional keyword. Though it compiles, I also stumbled upon this link where proto3 claims to have done away with required and optional field support.
protocolbuffers/protobuf#2497 (comment)
There was a problem hiding this comment.
Ohh. I see. Thanks for explaining.
There was a problem hiding this comment.
Actually that's not true anymore, optional is back with different semantics IIRC related to using the default value of a field when not set.
Adds a timestamp when the child goes to faulted state. If child has never faulted, this will be blank.