Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does openebs-lvm-controller use StatefulSet ? #196

Closed
iswbm opened this issue Jun 17, 2022 · 4 comments
Closed

Why does openebs-lvm-controller use StatefulSet ? #196

iswbm opened this issue Jun 17, 2022 · 4 comments
Assignees
@niladrih
Labels
kind/support Categorizes issue or PR as a support question

Comments

@iswbm
Copy link

iswbm commented Jun 17, 2022

When the node where openebs-lvm-controller is located goes down, the pod of lvm-controller will always be in terminating and will not be automatically started on other nodes.

So I wonder why does openebs-lvm-controller use StatefulSet ?

Are there any special considerations?
@niladrih
Copy link
Member

I remember a discussion where this decision was made. But I just cannot recall the reason at the moment. @pawanpraka1 @akhilerm @shubham14bajpai @kmova -- is there a reason for this decision?

@evgkrsk
Copy link
Contributor

evgkrsk commented Sep 21, 2023

Vote for Deployment.

evgkrsk added a commit to evgkrsk/lvm-localpv that referenced this issue Sep 22, 2023
@evgkrsk
Change lvm-controller's Kind from StatefulSet to Deployment (openebs#196
78a0443 
)
evgkrsk added a commit to evgkrsk/lvm-localpv that referenced this issue Sep 22, 2023
@evgkrsk
Change lvm-controller's Kind from StatefulSet to Deployment (openebs#196
1754ad7 
)

Signed-off-by: Evgenii Tereshkov <evg.krsk@gmail.com>
@evgkrsk evgkrsk mentioned this issue Sep 22, 2023
Closed
7 tasks
evgkrsk added a commit to evgkrsk/lvm-localpv that referenced this issue Sep 22, 2023
@evgkrsk
Change lvm-controller's Kind from StatefulSet to Deployment (openebs#196
70daa4b 
)

Signed-off-by: Evgenii Tereshkov <etereshkov@ozon.ru>
niladrih pushed a commit to niladrih/lvm-localpv that referenced this issue Mar 18, 2024
@evgkrsk @niladrih
Change lvm-controller's Kind from StatefulSet to Deployment (openebs#196
1456766 
)

Signed-off-by: Evgenii Tereshkov <etereshkov@ozon.ru>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih pushed a commit to niladrih/lvm-localpv that referenced this issue Mar 19, 2024
@evgkrsk @niladrih
Change lvm-controller's Kind from StatefulSet to Deployment (openebs#196
1549358 
)

Signed-off-by: Evgenii Tereshkov <etereshkov@ozon.ru>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih pushed a commit to niladrih/lvm-localpv that referenced this issue Mar 19, 2024
@evgkrsk @niladrih
Change lvm-controller's Kind from StatefulSet to Deployment (openebs#196
46b7061 
)

Signed-off-by: Evgenii Tereshkov <etereshkov@ozon.ru>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih added a commit that referenced this issue Mar 21, 2024
@niladrih @jeffrey4l
@Abhinandan-Purkait @evgkrsk
refactor(charts): move CRDs to a subchart (#284)
de4570f 
* ci: update GitHub Actions workflows

Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>

* refactor(charts): move CRDs to a subchart

Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>

* remove useless crd.enableInstall variable

Signed-off-by: Jeffrey Zhang <zhang.lei.fly@gmail.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>

* revert(charts): remove stale crd.volumeSnashots option

Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>

* feat(charts): disable hostNetwork on node plugin

Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>

* Change lvm-controller's Kind from StatefulSet to Deployment (#196)

Signed-off-by: Evgenii Tereshkov <etereshkov@ozon.ru>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>

* Fix PR number in changelogs

Signed-off-by: Evgenii Tereshkov <etereshkov@ozon.ru>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>

* refactor(charts): simplify CRD helm chart values

Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>

* doc: replace sts for deploy in chart README.md

Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>

---------

Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: Jeffrey Zhang <zhang.lei.fly@gmail.com>
Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
Signed-off-by: Evgenii Tereshkov <etereshkov@ozon.ru>
Co-authored-by: Jeffrey Zhang <zhang.lei.fly@gmail.com>
Co-authored-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
Co-authored-by: Evgenii Tereshkov <etereshkov@ozon.ru>
@dsharma-dc
Copy link
Contributor

@niladrih This issue can be closed now I think because the type has been changed to Deployment in PR #286 ?

@niladrih
Copy link
Member

This was fixed in v1.5.0 and is a part of OpenEBS 4.0.

@orville-wright orville-wright added the kind/support Categorizes issue or PR as a support question label May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niladrih niladrih

Labels
kind/support Categorizes issue or PR as a support question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(charts): Change lvm-controller's Kind from StatefulSet to Deployment (#196) evgkrsk/lvm-localpv
5 participants
@evgkrsk @orville-wright @iswbm @niladrih @dsharma-dc