Skip to content

Commit

Permalink
chore(bors): merge pull request #795
Browse files Browse the repository at this point in the history
795: Cherry-pick 794 r=tiagolobocastro a=tiagolobocastro

fix(replica/entity_id): ignore not implemented error

During upgrades some nodes are not.. updated.. so ignore the error

Co-authored-by: Tiago Castro <tiagolobocastro@gmail.com>
  • Loading branch information
mayastor-bors and tiagolobocastro committed Mar 28, 2024
2 parents 91d72fa + 05df0bd commit 69ffbf9
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions control-plane/agents/src/bin/core/nexus/operations_helper.rs
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,13 @@ impl OperationGuardArc<NexusSpec> {
replica_state.node.clone(),
);
if let Err(error) = node.set_replica_entity_id(&set_entity_id).await {
tracing::error!(
replica.uuid = %replica_state.uuid,
%error,
"Failed to set entity_id",
);
if error.tonic_code() != tonic::Code::Unimplemented {
tracing::error!(
replica.uuid = %replica_state.uuid,
%error,
"Failed to set entity_id",
);
}
}
}
}
Expand Down

0 comments on commit 69ffbf9

Please sign in to comment.