Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(drain): disallow node draining if ha is disabled #692

Merged
merged 3 commits into from
Nov 30, 2023
Merged

feat(drain): disallow node draining if ha is disabled #692

merged 3 commits into from
Nov 30, 2023

Conversation

Abhinandan-Purkait
Copy link
Member

@Abhinandan-Purkait Abhinandan-Purkait commented Nov 28, 2023 •
edited
Loading

Node Drain relies on the HA feature to move and reconnect the nexus. So if HA is disabled node drain will not work and can leave the volumes in an inconsistent state.

This PR restricts node draining if the HA is not enabled.

avishnu
avishnu approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@avishnu avishnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

tiagolobocastro
tiagolobocastro reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also ensure that on republish we never move the nexus?
Otherwise if we don't want to do that then we should change this config from disable_ha to disable_drain ?

@Abhinandan-Purkait
feat(agent-core): add disable-ha arg to core-agent
a76db62 
Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
@Abhinandan-Purkait
feat(drain): disallow drain when HA is disabled
d42e0d6 
Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
@Abhinandan-Purkait
feat(drain): disallow republish when HA is disabled
b4b3fb1 
Signed-off-by: Abhinandan Purkait <purkaitabhinandan@gmail.com>
@Abhinandan-Purkait
Copy link
Member Author

bors merge

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit baa101c into develop Nov 30, 2023
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the disable-drain-non-ha branch November 30, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@avishnu avishnu avishnu approved these changes

@chriswldenyer chriswldenyer Awaiting requested review from chriswldenyer

@niladrih niladrih Awaiting requested review from niladrih

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Abhinandan-Purkait @tiagolobocastro @avishnu