Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump kube from v0.85.0 to v0.87.2 and k8s-openapi from v0.19.0 to v0.20.0 #854

Merged

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Aug 30, 2024

This switches to the rustls backend, it's the default for the first time in this version, and thus fixes openebs/mayastor#1729 by way of the rustls-only fix of kube-rs/kube#991

This is the minimum change necessary to just fix the above issue. Probably this and other dependencies should be updated in addition to this PR.

Closes openebs/mayastor#1729

This also bumps the minimum k8s version to v1.22

@tiagolobocastro
Copy link
Contributor

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Aug 30, 2024
@bors-openebs-mayastor
Copy link

try

Timed out.

@tiagolobocastro
Copy link
Contributor

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Sep 12, 2024
@bors-openebs-mayastor
Copy link

try

Build failed:

@tiagolobocastro
Copy link
Contributor

oops had forgotten about this, sorry.
bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Sep 17, 2024
@tiagolobocastro
Copy link
Contributor

@niladrih you had another PR where you also upped the k8s deps, where did you stand there, can we go ahead and update kube and k8s api?

@bors-openebs-mayastor
Copy link

try

Build failed:

@tiagolobocastro
Copy link
Contributor

[2024-09-17T13:17:28.908Z] error: failed to run custom build command for `k8s-openapi v0.20.0`

[2024-09-17T13:17:28.908Z] 

[2024-09-17T13:17:28.908Z] Caused by:

[2024-09-17T13:17:28.908Z]   process didn't exit successfully: `/var/lib/jenkins/workspace/Mayastor-Control-Plane_trying_3/target/debug/build/k8s-openapi-30fb324d4b1d7f44/build-script-build` (exit status: 101)

[2024-09-17T13:17:28.908Z]   --- stdout

[2024-09-17T13:17:28.908Z]   cargo:rerun-if-env-changed=K8S_OPENAPI_ENABLED_VERSION

[2024-09-17T13:17:28.908Z] 

[2024-09-17T13:17:28.908Z]   --- stderr

[2024-09-17T13:17:28.908Z]   thread 'main' panicked at /var/lib/jenkins/.cargo/registry/src/index.crates.io-6f17d22bba15001f/k8s-openapi-0.20.0/build.rs:17:42:

[2024-09-17T13:17:28.908Z] 

[2024-09-17T13:17:28.908Z]   None of the v1_* features are enabled on the k8s-openapi crate.

[2024-09-17T13:17:28.908Z] 

[2024-09-17T13:17:28.908Z]   The k8s-openapi crate requires a feature to be enabled to indicate which version of Kubernetes it should support.

[2024-09-17T13:17:28.908Z] 

[2024-09-17T13:17:28.908Z]   If you're using k8s-openapi in a binary crate, enable the feature corresponding to the minimum version of API server that you want to support. In case your binary crate does not directly depend on k8s-openapi, add a dependency on k8s-openapi and enable the corresponding feature in it.

[2024-09-17T13:17:28.908Z] 

[2024-09-17T13:17:28.908Z]   If you're using k8s-openapi in a library crate, add a dev-dependency on k8s-openapi and enable one of the features there. This way the feature will be enabled when buildings tests and examples of your library, but not when building the library itself. In case your library crate does not directly depend on k8s-openapi, add a dev-dependency on k8s-openapi and enable the corresponding feature in it.

[2024-09-17T13:17:28.908Z] 

[2024-09-17T13:17:28.908Z]   Alternatively, when running commands that do not build dev dependencies such as `cargo check` and `cargo doc`, you can set the `K8S_OPENAPI_ENABLED_VERSION` environment variable, such as `K8S_OPENAPI_ENABLED_VERSION=1.50`.

[2024-09-17T13:17:28.908Z] 

[2024-09-17T13:17:28.908Z]   Library crates *must not* enable any features in their direct dependency on k8s-openapi, only in their dev-dependency. The choice of which Kubernetes version to support should be left to the final binary crate, so only binary crates should enable a specific feature. If library crates also enabled features, it could cause multiple features to be enabled simultaneously, which k8s-openapi does not support.

[2024-09-17T13:17:28.908Z] 

[2024-09-17T13:17:28.908Z]   If your library crate only supports a single specific version or a specific range of versions of Kubernetes, please use the `k8s_if_*` version-specific macros or a build script to emit different code based on which feature gets enabled in the end.

[2024-09-17T13:17:28.908Z] 

[2024-09-17T13:17:28.908Z]   If you believe you *have* enabled a version feature and should not be seeing this error, check your Cargo.lock or run `cargo tree -i k8s-openapi` to ensure that this version of k8s-openapi is the only one being used in your project.

[2024-09-17T13:17:28.908Z] 

[2024-09-17T13:17:28.908Z]   See the k8s-openapi docs for more details.

[2024-09-17T13:17:28.908Z]           

[2024-09-17T13:17:28.908Z]   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[2024-09-17T13:17:28.908Z] warning: build failed, waiting for other jobs to finish...

I suspect you might need to update the kube crates across the tomls, which means updating the k8s api, which again brings me to ping @niladrih about his previous attempt

@michaelbeaumont michaelbeaumont changed the title build: bump kube dependency from v0.85.0 to v0.87.2 build: bump kube from v0.85.0 to v0.87.2 and k8s-openapi from v0.19.0 to v0.20.0 Oct 6, 2024
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@tiagolobocastro
Copy link
Contributor

bors delegate+

@bors-openebs-mayastor
Copy link

✌️ michaelbeaumont can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@michaelbeaumont
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Oct 6, 2024
@bors-openebs-mayastor
Copy link

try

Build succeeded:

Copy link
Contributor

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@tiagolobocastro
Copy link
Contributor

I think you can also comment 'bors merge', whenever you are ready @michaelbeaumont :)

@michaelbeaumont
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 1406608 into openebs:develop Oct 7, 2024
6 checks passed
@michaelbeaumont michaelbeaumont deleted the fix/update-kube-sni-fix branch October 7, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

csi-node fails to start with kube::Client hostname mismatch when contacting the k8s API server
3 participants