Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(snapshot): plugin changes for snapshot operation #500

Merged
merged 1 commit into from
May 13, 2024
Merged

feat(snapshot): plugin changes for snapshot operation #500

merged 1 commit into from
May 13, 2024

Conversation

hrudaya21
Copy link
Contributor

Description

  1. kubectl plugin to set volume attribute (max_snapshots)
  2. kubectl plugin to show volume snapshot topology.

Motivation and Context

This plugin will give more detail information about volume snapshot operation.

Regression

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.

@hrudaya21
feat(snapshot): plugin changes for snapshot operation
4a62236 
Signed-off-by: Hrudaya <hrudayaranjan.sahoo@datacore.com>
@hrudaya21
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request May 13, 2024
Try #500:
dbb9848
@bors-openebs-mayastor
Copy link
Contributor

try

Build succeeded:

@hrudaya21
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link
Contributor

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit a007317 into develop May 13, 2024
5 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the snapshot_plugin branch May 13, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinhaashish sinhaashish sinhaashish approved these changes

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@Abhinandan-Purkait Abhinandan-Purkait Awaiting requested review from Abhinandan-Purkait

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hrudaya21 @tiagolobocastro @sinhaashish