Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: various release chart update fixes #579

Merged
merged 1 commit into from
Dec 12, 2024
Merged

ci: various release chart update fixes #579

merged 1 commit into from
Dec 12, 2024

Conversation

tiagolobocastro
Copy link
Contributor 

ci: various release chart update fixes

Don't update the chart on a pre-release
Set missing base branch for pull-request
Add stricter release validation
Add more tests

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>

@tiagolobocastro
ci: various release chart update fixes
5fd5c0d 
Don't update the chart on a pre-release
Set missing base branch for pull-request
Add stricter release validation
Add more tests

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
niladrih
niladrih reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@niladrih niladrih left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very clear on what this PR does..

Don't update the chart on a pre-release

What is the context here?

scripts/helm/publish-chart-yaml.sh Show resolved Hide resolved
@tiagolobocastro
Copy link
Contributor Author

I'm not very clear on what this PR does..

Don't update the chart on a pre-release

What is the context here?

A GitHub action bumps the release version on Chart.yaml on release but it's failing on pre-releases.
This fixes it.

@tiagolobocastro
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link
Contributor

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 6b9e0ea into release/2.7 Dec 12, 2024
5 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the rel-update-fix branch December 12, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsharma-dc dsharma-dc dsharma-dc approved these changes

@niladrih niladrih niladrih approved these changes

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@sinhaashish sinhaashish Awaiting requested review from sinhaashish

@abhilashshetty04 abhilashshetty04 Awaiting requested review from abhilashshetty04

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiagolobocastro @Abhinandan-Purkait @niladrih @dsharma-dc