feat(chart): use system-critical priorityClass for localpv dsp-operator and csi ctrl #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Or should we just set it in the values.yaml? |
|
@tiagolobocastro the name of the priorityclass is "{{ .Release.Name }}-cluster-critical" |
Yeah I'm saying set that on the values.yaml |
niladrih
force-pushed
the
priorityClassForEveryone
branch
from
a7b4350 to
9e74521
Compare
tiagolobocastro
approved these changes
Jan 22, 2025
…or and csi ctrl Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih
force-pushed
the
priorityClassForEveryone
branch
from
9e74521 to
0f9e0a9
Compare
niladrih
changed the title
abhilashshetty04
approved these changes
Jan 23, 2025
|
bors merge |
|
bors cancel |
|
Canceled. |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One way of using the system-critical priorityClass with the localpv provisioner could be
However, it's difficult to set the localpv parameters dynamically.
WDYT @tiagolobocastro @Abhinandan-Purkait?