Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pool): blobstore cluster size to be set during pool creation through grpc parameter value #1512

Merged
merged 1 commit into from
Oct 4, 2023
Merged

feat(pool): blobstore cluster size to be set during pool creation through grpc parameter value #1512

merged 1 commit into from
Oct 4, 2023

Conversation

hrudaya21
Copy link
Contributor

@hrudaya21 hrudaya21 commented Sep 22, 2023 •
edited
Loading

  • The default cluster size considered by SPDK is 4MiB.
  • During pool creation, cluster_size can be taken from the gRPC and consider that value.
  • The cluster_size can be consider with multiple of 1MiB.
  • If the cluster_size passed not multiple of 1MiB, then default 4MiB cluster size will be considered for the pool creation.

@hrudaya21 hrudaya21 requested review from tiagolobocastro and dsharma-dc and removed request for chriswldenyer September 22, 2023 13:16
@hrudaya21
Copy link
Contributor Author

Do We need to have any checks in the dataplane to limit the maximum cluster size, to ensure this field is not exploit with very high value in gRPC request ?

dsavitskiy
dsavitskiy requested changes Sep 29, 2023
View reviewed changes
io-engine/src/lvs/lvs_store.rs Outdated Show resolved Hide resolved
@dsavitskiy
Copy link
Contributor

Do We need to have any checks in the dataplane to limit the maximum cluster size, to ensure this field is not exploit with very high value in gRPC request ?

Yes indeed, we have to. Probably something around 64Mb~128Mb ? @tiagolobocastro ?

@tiagolobocastro
Copy link
Contributor

Do We need to have any checks in the dataplane to limit the maximum cluster size, to ensure this field is not exploit with very high value in gRPC request ?

Yes indeed, we have to. Probably something around 64Mb~128Mb ? @tiagolobocastro ?

IIRC the default within the blobstore is 1GiB, maybe that could be the max, or is it probably too much?

tiagolobocastro
tiagolobocastro reviewed Sep 29, 2023
View reviewed changes
io-engine/src/bin/io-engine-client/v1/pool_cli.rs Outdated Show resolved Hide resolved
io-engine/src/bin/io-engine-client/v1/pool_cli.rs Outdated Show resolved Hide resolved
io-engine/src/lvs/lvs_store.rs Outdated Show resolved Hide resolved
@hrudaya21
Copy link
Contributor Author

Do We need to have any checks in the dataplane to limit the maximum cluster size, to ensure this field is not exploit with very high value in gRPC request ?

Yes indeed, we have to. Probably something around 64Mb~128Mb ? @tiagolobocastro ?

IIRC the default within the blobstore is 1GiB, maybe that could be the max, or is it probably too much?

I think We can keep it 1GiB. As per the SPDK documentation, If the BlobStore Size is multiple of GBs, then cluster size can be 1GiB.

@hrudaya21 hrudaya21 force-pushed the feature/GTM_1385 branch 3 times, most recently from 76a2fdf to addbe42 Compare September 29, 2023 14:27
@hrudaya21
Copy link
Contributor Author

bors try

bors bot pushed a commit that referenced this pull request Oct 4, 2023
Try #1512:
aae0107
@bors
Copy link
Contributor

bors bot commented Oct 4, 2023

try

Build failed:

@hrudaya21
Copy link
Contributor Author

bors try

bors bot pushed a commit that referenced this pull request Oct 4, 2023
Try #1512:
54008e8
@bors
Copy link
Contributor

bors bot commented Oct 4, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@hrudaya21
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Oct 4, 2023
@hrudaya21
Merge #1512
9e42b76 
1512: feat(pool): blobstore cluster size to be set during pool creation through grpc parameter value r=hrudaya21 a=hrudaya21

- The default cluster size considered by SPDK is 4MiB.
- During pool creation, cluster_size can be taken from the gRPC and consider that value.
- The cluster_size can be consider with multiple of 4MiB.
- If the cluster_size passed not multiple of 1MiB, then default 4MiB cluster size will be considered for the pool creation.

Co-authored-by: Hrudaya <hrudayaranjan.sahoo@datacore.com>
@hrudaya21
feat(pool): blobstore cluster size to be set during pool creation thr…
ee2ce00 
…ough grpc parameter value

Signed-off-by: Hrudaya <hrudayaranjan.sahoo@datacore.com>
@bors
Copy link
Contributor

bors bot commented Oct 4, 2023

Canceled.

@hrudaya21
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 4, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit c1f6b0a into openebs:develop Oct 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@dsavitskiy dsavitskiy dsavitskiy approved these changes

@dsharma-dc dsharma-dc Awaiting requested review from dsharma-dc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hrudaya21 @dsavitskiy @tiagolobocastro