Various fixes for idempotency, error messages and concurrency #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tiagolobocastro
commented
Nov 28, 2023
•
tiagolobocastro
commented
tiagolobocastro
requested review from
dsavitskiy,
hrudaya21,
Abhinandan-Purkait and
dsharma-dc
hrudaya21
approved these changes
Nov 28, 2023
Allows the control-plane to determine what the inner error was. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
tiagolobocastro
force-pushed
the
fix-lvs
branch
from
e1c73be to
ed15f55
Compare
ChildNotFound error had an invalid error message. Don't output NotFound messages for ptpl. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
Some args were not setup correctly since clap update. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
dsharma-dc
approved these changes
Nov 29, 2023
System test is using wipe replicas, which can block list calls from the control-plane and thus confusing it thinking the node is not responding. Let's allow concurrent wipe with lists, since wiping doesn't destroy or modify replica metadata anyway. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
tiagolobocastro
changed the title
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Nov 29, 2023
1552: Various fixes for idempotency, error messages and concurrency r=tiagolobocastro a=tiagolobocastro
fix(grpc/snapshot): snapshot grpc should use replica svc
We should not allow concurrent snapshot and replica operations as they might clash.
todo: allow per-resource locking
Furthermore it was observed that holding a bdev ptr whilst it's being deleted might
cause a crash, we need to determine if this was to do with it being held over an
async point, or a more general problem.
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
---
ci(test/wipe/replicas): allow list and wipe replicas
System test is using wipe replicas, which can block list calls from the control-plane
and thus confusing it thinking the node is not responding.
Let's allow concurrent wipe with lists, since wiping doesn't destroy or modify
replica metadata anyway.
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
---
fix(io-engine/client): fix cli args
Some args were not setup correctly since clap update.
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
---
fix: bad error message
ChildNotFound error had an invalid error message.
Don't output NotFound messages for ptpl.
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
---
fix(lvs/status): fixup missing bdev errors
Allows the control-plane to determine what the inner error was.
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
Co-authored-by: Tiago Castro <tiagolobocastro@gmail.com>
|
Build failed: |
We should not allow concurrent snapshot and replica operations as they might clash. todo: allow per-resource locking Furthermore it was observed that holding a bdev ptr whilst it's being deleted might cause a crash, we need to determine if this was to do with it being held over an async point, or a more general problem. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
tiagolobocastro
force-pushed
the
fix-lvs
branch
from
a7cf92a to
e672fd5
Compare
|
bors merge |
|
bors cancel |
|
Canceled. |
Show human readable value. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Nov 29, 2023
1552: Various fixes for idempotency, error messages and concurrency r=tiagolobocastro a=tiagolobocastro
fix(grpc/snapshot): snapshot grpc should use replica svc
We should not allow concurrent snapshot and replica operations as they might clash.
todo: allow per-resource locking
Furthermore it was observed that holding a bdev ptr whilst it's being deleted might
cause a crash, we need to determine if this was to do with it being held over an
async point, or a more general problem.
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
---
ci(test/wipe/replicas): allow list and wipe replicas
System test is using wipe replicas, which can block list calls from the control-plane
and thus confusing it thinking the node is not responding.
Let's allow concurrent wipe with lists, since wiping doesn't destroy or modify
replica metadata anyway.
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
---
fix(io-engine/client): fix cli args
Some args were not setup correctly since clap update.
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
---
fix: bad error message
ChildNotFound error had an invalid error message.
Don't output NotFound messages for ptpl.
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
---
fix(lvs/status): fixup missing bdev errors
Allows the control-plane to determine what the inner error was.
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
Co-authored-by: Tiago Castro <tiagolobocastro@gmail.com>
|
Build failed: |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.