Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use transport specific nvmf uri scheme #1726

Merged
merged 1 commit into from
Sep 17, 2024
Merged

feat: use transport specific nvmf uri scheme #1726

merged 1 commit into from
Sep 17, 2024

Conversation

dsharma-dc
Copy link
Contributor

No description provided.

@dsharma-dc dsharma-dc marked this pull request as ready for review September 9, 2024 06:54
tiagolobocastro
tiagolobocastro reviewed Sep 9, 2024
View reviewed changes
io-engine/src/target/nvmf.rs Outdated Show resolved Hide resolved
io-engine/src/bdev/dev.rs Outdated Show resolved Hide resolved
@dsharma-dc dsharma-dc force-pushed the nvmf_uri branch 2 times, most recently from 3307f11 to 514903a Compare September 12, 2024 05:05
@dsharma-dc
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Sep 16, 2024
Try #1726:
2ad5211
@bors-openebs-mayastor
Copy link

try

Build failed:

@dsharma-dc
Copy link
Contributor Author

try

Build failed:

Adapt a regex in a test according to new uri scheme.

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Sep 16, 2024
Try #1726:
ece9673
@bors-openebs-mayastor
Copy link

try

Build failed:

@dsharma-dc
feat: use transport specific nvmf uri scheme
fe8cc56 
Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>
@dsharma-dc
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Sep 17, 2024
Try #1726:
16ef6b8
@bors-openebs-mayastor
Copy link

try

Build succeeded:

@dsharma-dc
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 1c537b7 into openebs:develop Sep 17, 2024
4 checks passed
@dsharma-dc dsharma-dc deleted the nvmf_uri branch September 17, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gila gila gila left review comments

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@dsavitskiy dsavitskiy dsavitskiy approved these changes

@abhilashshetty04 abhilashshetty04 Awaiting requested review from abhilashshetty04

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dsharma-dc @dsavitskiy @tiagolobocastro @gila @Abhinandan-Purkait