test: add a test to enable and test rdma connect #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dsharma-dc
commented
Oct 23, 2024
dsharma-dc
commented
- Added a simple test to create and publish a nexus. Connect it over rdma.
- The connect API is modified to take transport parameter.
- The test automatically detects a suitable interface to create a soft-RDMA device, creates it and deletes it at the end of the test.
dsharma-dc
force-pushed
the
composer_nw
branch
from
fde28b2
to
e6fd96c
Compare
|
The changes for composer dependencies are here: openebs/mayastor-dependencies#96 |
dsharma-dc
force-pushed
the
composer_nw
branch
from
e6fd96c
to
5c64d04
Compare
Abhinandan-Purkait
approved these changes
Oct 25, 2024
scripts/cargo-test.sh
Outdated
| @@ -19,6 +19,12 @@ trap cleanup_handler INT QUIT TERM HUP EXIT | |||
| export PATH=$PATH:${HOME}/.cargo/bin | |||
| set -euxo pipefail | |||
|
|
|||
| # setup extra modules as we need rdma-rxe for rdma tests | |||
| sudo apt -y install rdmacm-utils | |||
There was a problem hiding this comment.
hmm you can't assume everyone and ci is using ubuntu.
I think we should leave this out, should be part of pre-requisites, just like hugepages and nvme-tcp
There was a problem hiding this comment.
removed installation of package and added warning if kernel modules aren't installed.
dsharma-dc
force-pushed
the
composer_nw
branch
3 times, most recently
from
f542244
to
f4d3f01
Compare
|
bors try |
tryBuild failed: |
tiagolobocastro
approved these changes
Oct 28, 2024
Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>
dsharma-dc
force-pushed
the
composer_nw
branch
from
f4d3f01
to
acc6c2d
Compare
|
bors try |
tryBuild failed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.