Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(localpv): fixing volumesnapshot restoresize zero #419

Closed
wants to merge 1 commit into from

Conversation

chinglinwen
Copy link

@chinglinwen chinglinwen commented Jun 16, 2022

  • while return snapshot response, also return the size

Pull Request template

Please, go through these steps before you submit a PR.

Why is this PR required? What issue does it fix?:

#416

What this PR does?:

return extra size info when return CreateSnapshot response

Does this PR require any upgrade changes?:
I think normal flow doesn't change, only affect external repo, like kubevirt depends on it to create PVC success.

If the changes in this PR are manually verified, list down the scenarios covered::
After this fix, the snapshot should have non-zero restore size.

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

This is about my first pull request.

I'm not sure if the size return is correct, mainly to fix my kubevirt usage.

Checklist:

- while return snapshot response, also return the size
@hrudaya21
Copy link
Contributor

@chinglinwen Could you please do DCO Sign-off.

@niladrih
Copy link
Member

niladrih commented Oct 4, 2023

@chinglinwen -- Could you rebase your PR branch with develop, thanks!

@hrudaya21
Copy link
Contributor

This Code has been merged in #480 PR.

@hrudaya21 hrudaya21 closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

volumesnapshot restoreSize is not set when returning from createSnapshot response
3 participants