-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin): Fix ability to have custom value for openebs.io/nodeid #451
Conversation
9ff5475
to
c854109
Compare
@niladrih when you have a moment would you mind taking a peak at this PR. It is a critical fix in order for our deployment. Without this change, we will not be able to perform node upgrades within the cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have some tests for the changes to both go classes
@jnels124 Can you please rebase your code. Also please add the testing steps in the Documentation file as part of this PR. |
@hrudaya21 I have rebased and updated install documentation to reference existing documentation. Please let me know if anything else is needed to get this merged. |
153a256
to
318214c
Compare
See #489. Might still be broken. |
Signed-off-by: Jesse Nelson <jesse@swirldslabs.com>
Signed-off-by: Jesse Nelson <jesse@swirldslabs.com>
Signed-off-by: Jesse Nelson <jesse@swirldslabs.com>
Signed-off-by: Jesse Nelson <jesse@swirldslabs.com>
Signed-off-by: Jesse Nelson <jesse@swirldslabs.com>
Signed-off-by: Jesse Nelson <jesse@swirldslabs.com>
Signed-off-by: Jesse Nelson <jesse@swirldslabs.com>
318214c
to
1058228
Compare
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?:
This PR is required in order to allow a ZFS volume to be moved to another node
What this PR does?:
This pr fixes existing logic that attempts to retrieve a node using the name and instead retrieves the node using the nodeid label
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
These changes were manually verified by doing the following:
kubectl label node <Node> openebs.io/nodeid=value-1
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>