Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart): correct default values for init containers and additional volumes #475

Closed
wants to merge 1 commit into from

Conversation

jnels124
Copy link
Contributor

Pull Request template

Please, go through these steps before you submit a PR.

Why is this PR required? What issue does it fix?:
Fixes a small config error in default values.yaml

What this PR does?:
initializes to an object instead of array
Does this PR require any upgrade changes?:
no
If the changes in this PR are manually verified, list down the scenarios covered::
Applied chart and verified warnings were gone and values functioned as intended
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

@niladrih niladrih self-assigned this Sep 19, 2023
@jnels124 jnels124 force-pushed the config-fix branch 3 times, most recently from 36e5916 to cd8514b Compare November 1, 2023 14:30
Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnels124 arrays seem appropriate with initContainers and volumes. Why is this change required?

@jnels124
Copy link
Contributor Author

jnels124 commented Dec 12, 2023

@niladrih because the expected structure of the config is as such:

zfsNode:
   additionalVolumes:
     node:
       hostPath:
         path: /
     scripts:
       configMap:
         name: "{{ .Release.Name }}-zfs-init"
         defaultMode: 0744

The key for the additionalVolumes dict is used in the template and the template requires this structure

@jnels124 jnels124 requested a review from niladrih December 29, 2023 00:17

Verified

This commit was signed with the committer’s verified signature.
jnels124 Jesse Nelson
… volumes

Signed-off-by: Jesse Nelson <jesse@swirldslabs.com>
@jnels124 jnels124 closed this Feb 20, 2024
@jnels124 jnels124 deleted the config-fix branch February 20, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default value in values.yaml triggers warning message on install
2 participants