fix(path): handle trailing slash (/) in kubelet directory #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: w3aman <aman.gupta@mayadata.io>
|
Perhaps we can have the same impl as openebs/lvm-localpv#297, either modify here or there? |
I think Better to use template function. |
Abhinandan-Purkait
approved these changes
May 22, 2024
|
This PR would be reviewed and would eventually be cherry-picked into the next helm release once we achieve the approval quorum. |
sinhaashish
approved these changes
Jul 3, 2024
Signed-off-by: w3aman <aman.gupta@mayadata.io>
|
Has been cherry-picked in #552 . Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR required? What issue does it fix?:
Fixes: #530
What this PR does?:
Handle the condition where user may or may not give the kubelet path with trailing slash (/) in --set command for custom kubelet configuration.