Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(localpv): comment fixes & better documentation related to thinprovision parameter #563

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

abuisine
Copy link
Contributor

Pull Request template

Please, go through these steps before you submit a PR.

Why is this PR required? What issue does it fix?:
Fixes #560

What this PR does?:
Remove misleading comments and enrich documentation.

Does this PR require any upgrade changes?:
No

If the changes in this PR are manually verified, list down the scenarios covered::
N/A

Any additional information for your reviewer? :
N/A

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/website is used to track them:

@abuisine abuisine force-pushed the doc-thinprov-default branch 2 times, most recently from 9dd2809 to 1b43f65 Compare July 16, 2024 10:05
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.53%. Comparing base (1c29ecd) to head (1b43f65).
Report is 1 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #563   +/-   ##
========================================
  Coverage    99.53%   99.53%           
========================================
  Files            1        1           
  Lines          431      431           
========================================
  Hits           429      429           
  Misses           1        1           
  Partials         1        1           
Flag Coverage Δ
bddtests 99.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Abhinandan-Purkait Abhinandan-Purkait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abuisine, can you please undo the changes on the files v1/zfsvolume.go and v1alpha1/zfsvolume.go. Those changes cannot just go in without running the manifest generation and the kubegen to generate the autogenerated code. We will take that up on a different PR as running the generators will change a few files.

LGTM, on the doc changes.

Also you might want to sign your commit for DCO to pass. Thanks

@abuisine abuisine force-pushed the doc-thinprov-default branch 3 times, most recently from 18f514f to 835acaa Compare July 17, 2024 10:09
Copy link
Member

@Abhinandan-Purkait Abhinandan-Purkait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @niladrih @avishnu @tiagolobocastro @sinhaashish Can we have some more reviews here?

@Abhinandan-Purkait
Copy link
Member

@balaharish7 Please update here accordingly once this is merged.

Signed-off-by: Alexandre Buisine <alexandre.buisine@enix.fr>
@abuisine abuisine force-pushed the doc-thinprov-default branch from 835acaa to cc098f9 Compare July 17, 2024 13:02
@abuisine
Copy link
Contributor Author

@Abhinandan-Purkait I just did, and rebased, should be good to go

@Abhinandan-Purkait
Copy link
Member

@abuisine Thanks.

@Abhinandan-Purkait Abhinandan-Purkait merged commit e9a9f95 into openebs:develop Jul 17, 2024
3 checks passed
@abuisine abuisine deleted the doc-thinprov-default branch July 17, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No clear default value for thin provisioning of filesystems
4 participants