-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(localpv): comment fixes & better documentation related to thinprovision parameter #563
Conversation
9dd2809
to
1b43f65
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #563 +/- ##
========================================
Coverage 99.53% 99.53%
========================================
Files 1 1
Lines 431 431
========================================
Hits 429 429
Misses 1 1
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @abuisine, can you please undo the changes on the files v1/zfsvolume.go
and v1alpha1/zfsvolume.go
. Those changes cannot just go in without running the manifest generation and the kubegen to generate the autogenerated code. We will take that up on a different PR as running the generators will change a few files.
LGTM, on the doc changes.
Also you might want to sign your commit for DCO to pass. Thanks
18f514f
to
835acaa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @niladrih @avishnu @tiagolobocastro @sinhaashish Can we have some more reviews here?
@balaharish7 Please update here accordingly once this is merged. |
Signed-off-by: Alexandre Buisine <alexandre.buisine@enix.fr>
835acaa
to
cc098f9
Compare
@Abhinandan-Purkait I just did, and rebased, should be good to go |
@abuisine Thanks. |
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?:
Fixes #560
What this PR does?:
Remove misleading comments and enrich documentation.
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
N/A
Any additional information for your reviewer? :
N/A
Checklist:
<type>(<scope>): <subject>