fix(reservation): update reservation on volume resize #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sinhaashish <ashi.sinha.87@gmail.com>
|
Fixes #568 |
Comment on lines
+302
to
+305
| if vol.Spec.ThinProvision == "no" { | ||
| reservationProperty := "reservation=" + vol.Spec.Capacity | ||
| ZFSVolArg = append(ZFSVolArg, "-o", reservationProperty) | ||
| } |
7 tasks
|
I implemented QuotaType support here #595 |
|
closing this as its addressed on PR #595 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?:
What this PR does?:
Does this PR require any upgrade changes?:
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>PLEASE REMOVE BELOW INFORMATION BEFORE SUBMITTING
The PR title message must follow convention:
<type>(<scope>): <subject>.Where:
typeis defining if release will be triggering after merging submitted changes, details in CONTRIBUTING.md.Most common types are:
feat- for new features, not a new feature for build scriptfix- for bug fixes or improvements, not a fix for build scriptchore- changes not related to production codedocs- changes related to documentationstyle- formatting, missing semi colons, linting fix etc; no significant production code changestest- adding missing tests, refactoring tests; no production code changerefactor- refactoring production code, eg. renaming a variable or function name, there should not be any significant production code changesscopeis a single word that best describes where the changes fit.Most common scopes are like:
localpv,jiva,cstor)provisioning,backup,restore,exporter)api,webhook,cast,upgrade)tests,bdd)version,build,log,travis)subjectis a single line brief description of the changes made in the pull request.