Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

Retry page load errors #224

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Retry page load errors #224

merged 1 commit into from
Feb 19, 2019

Conversation

jmbowman
Copy link
Contributor

Changed PageLoadError and WrongPageError to inherit from WebDriverException so they'll trigger retries in wait_for_* method loops instead of failing the test outright; sometimes these get triggered while the browser is still in the middle of loading the next page.

Also ran make upgrade to update dependencies, which prompted a few other fixes:

  • Make format strings Unicode to satisfy a new edx-pylint check
  • Stop using some deprecated aspects of the selenium package API
  • Consolidate dependency version restrictions in requirements/constraints.txt

@codecov-io
Copy link

codecov-io commented Feb 14, 2019

Codecov Report

Merging #224 into master will increase coverage by 1.19%.
The diff coverage is 92.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   88.03%   89.22%   +1.19%     
==========================================
  Files          10       10              
  Lines         919      919              
  Branches      152      152              
==========================================
+ Hits          809      820      +11     
+ Misses         72       64       -8     
+ Partials       38       35       -3
Impacted Files Coverage Δ
bok_choy/a11y/a11y_audit.py 95.74% <100%> (ø) ⬆️
bok_choy/a11y/axe_core_ruleset.py 95.28% <100%> (ø) ⬆️
bok_choy/page_object.py 97.28% <100%> (ø) ⬆️
bok_choy/web_app_test.py 85.52% <100%> (+9.21%) ⬆️
bok_choy/javascript.py 78.43% <100%> (ø) ⬆️
bok_choy/a11y/axs_ruleset.py 94.64% <100%> (ø) ⬆️
bok_choy/query.py 98.54% <100%> (ø) ⬆️
bok_choy/browser.py 71.69% <66.66%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eed593a...eed686f. Read the comment docs.

Copy link
Contributor

@estute estute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching this!

@jmbowman jmbowman force-pushed the jmbowman/retry_page_load_errors branch from b5fe66e to eed686f Compare February 19, 2019 20:08
@jmbowman jmbowman merged commit 216effb into master Feb 19, 2019
@jmbowman jmbowman deleted the jmbowman/retry_page_load_errors branch February 19, 2019 21:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants