Switch to failed_when structure

playbooks/edx-east/manage_edxapp_users_and_groups.yml

@@ -99,17 +99,5 @@
         {% if item.get('unusable_password') %}--unusable-password{% endif %}
         {% if item.get('initial_password_hash') %}--initial-password-hash {{ item.initial_password_hash | quote }}{% endif %}
       with_items: django_users
-      ignore_errors: yes
       register: manage_users_result
-
-# Note that we're doing something a bit odd with this play. Unfortunately, it appears that the
-# version of Ansible we're using (1.9.3-edx as of October 2016) does not support variable statements
-# in the `ignore_errors` field. As a result, we're capturing the result of that play, and using it
-# to determine if we execute an explicit `fail` play.
-
-    - name: "Managing users fails on error unless {{ ignore_user_creation_errors }}"
-      fail: item
-      when:
-        - item|failed
-        - not ignore_user_creation_errors | bool
-      with_items: manage_users_result.results
+      failed_when: (manage_users_result | failed) and not (ignore_user_creation_errors | bool)