fix: fix error response

ecommerce/bff/subscriptions/tests/test_subscription_views.py

@@ -92,12 +92,12 @@ def test_with_invalid_sku(self):
         url = reverse('bff:subscriptions:product-entitlement-info')
         response = self.client.get(url, data=[('sku', 1), ('sku', 2)])
         self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
-        expected_data = 'Products with SKU(s) [1, 2] do not exist.'
-        self.assertEqual(response.content.decode('utf-8'), expected_data)
+        expected_data = {'error': 'Products with SKU(s) [1, 2] do not exist.'}
+        self.assertCountEqual(json.loads(response.content.decode('utf-8')), expected_data)
 
     def test_with_empty_sku(self):
         url = reverse('bff:subscriptions:product-entitlement-info')
         response = self.client.get(url)
         self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
-        expected_data = 'No SKUs provided.'
-        self.assertEqual(response.content.decode('utf-8'), expected_data)
+        expected_data = {'error': 'No SKUs provided.'}
+        self.assertCountEqual(json.loads(response.content.decode('utf-8')), expected_data)

ecommerce/bff/subscriptions/views.py

@@ -3,15 +3,14 @@
 from django.http import HttpResponseBadRequest
 from django.utils.html import escape
 from oscar.core.loading import get_model
-from rest_framework import generics
+from rest_framework import generics, status
 from rest_framework.permissions import IsAuthenticated
 from rest_framework.response import Response
 
 from ecommerce.bff.subscriptions.permissions import CanGetProductEntitlementInfo
 from ecommerce.bff.subscriptions.serializers import CourseEntitlementInfoSerializer
 from ecommerce.extensions.api.exceptions import BadRequestException
 from ecommerce.extensions.api.throttles import ServiceUserThrottle
-from ecommerce.extensions.basket.exceptions import BadRequestException
 from ecommerce.extensions.partner.shortcuts import get_partner_for_site
 
 logger = logging.getLogger(__name__)
@@ -41,7 +40,7 @@ def get(self, request, *args, **kwargs):
                                  "does not have a UUID attribute or mode is None")
             return Response(data)
         except BadRequestException as e:
-            return HttpResponseBadRequest(str(e))
+            return Response({'error': str(e)}, status=status.HTTP_400_BAD_REQUEST)
 
     def _get_available_products(self, products):
         unavailable_product_ids = []