fix: add logging and test

ecommerce/bff/subscriptions/tests/test_subscription_views.py

@@ -1,5 +1,6 @@
 import json
 import uuid
+from unittest import mock
 
 from django.urls import reverse
 from oscar.core.loading import get_model
@@ -8,9 +9,8 @@
 
 from ecommerce.core.constants import COURSE_ENTITLEMENT_PRODUCT_CLASS_NAME
 from ecommerce.coupons.tests.mixins import DiscoveryMockMixin
-from ecommerce.courses.tests.factories import CourseFactory
 from ecommerce.extensions.catalogue.tests.mixins import DiscoveryTestMixin
-from ecommerce.tests.factories import PartnerFactory, ProductFactory, StockRecordFactory
+from ecommerce.tests.factories import ProductFactory
 from ecommerce.tests.testcases import TestCase
 
 Catalog = get_model('catalogue', 'Catalog')
@@ -56,7 +56,8 @@ def test_with_skus(self):
         ]
         self.assertCountEqual(json.loads(response.content.decode('utf-8')), expected_data)
 
-    def test_with_valid_and_invalid_products(self):
+    @mock.patch('ecommerce.bff.subscriptions.views.logger.error')
+    def test_with_valid_and_invalid_products(self, mock_log):
         product_class, _ = ProductClass.objects.get_or_create(name=COURSE_ENTITLEMENT_PRODUCT_CLASS_NAME)
 
         product1 = ProductFactory(title="test product 1", product_class=product_class, stockrecords__partner=self.partner)
@@ -75,6 +76,9 @@ def test_with_valid_and_invalid_products(self):
         response = self.client.get(url, data=[('sku', product1.stockrecords.first().partner_sku),
                                               ('sku', product2.stockrecords.first().partner_sku)
                                               ])
+
+        mock_log.assert_called_once_with(f"B2C_SUBSCRIPTIONS: Product {product2}"
+                                         f"does not have a UUID attribute or mode is None")
         self.assertEqual(response.status_code, status.HTTP_200_OK)
         expected_data = [
             {'course_uuid': product1.attr.UUID, 'mode': product1.attr.certificate_type}

ecommerce/bff/subscriptions/views.py

@@ -28,11 +28,13 @@ def get(self, request, *args, **kwargs):
             skus = self._get_skus(self.request)
             products = self._get_products_by_skus(skus)
             available_products = self._get_available_products(products)
-            data = [
-                {'course_uuid': product.attr.UUID, 'mode': self._mode_for_product(product)}
-                for product in available_products
-                if hasattr(product.attr, 'UUID') and self._mode_for_product(product) is not None
-            ]
+            data = []
+            for product in available_products:
+                if hasattr(product.attr, 'UUID') and self._mode_for_product(product) is not None:
+                    data.append({'course_uuid': product.attr.UUID, 'mode': self._mode_for_product(product)})
+                else:
+                    logger.error(f"B2C_SUBSCRIPTIONS: Product {product}"
+                                    "does not have a UUID attribute or mode is None")
             return Response(data)
         except BadRequestException as e:
             return HttpResponseBadRequest(str(e))