Upgraded frontend-build version to v12 #51
Conversation
Codecov ReportBase: 49.02% // Head: 49.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 49.02% 49.12% +0.09%
==========================================
Files 76 76
Lines 2005 2003 -2
Branches 372 372
==========================================
+ Hits 983 984 +1
+ Misses 988 985 -3
Partials 34 34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…g into bilalqamar95/frontend-build-upgrade
src/generic/LoadingPage.jsx
Outdated
| </div> | ||
| </Col> | ||
| ); | ||
| function LoadingPage({ loadingMessage }) { |
There was a problem hiding this comment.
It seems all of the const components have been replaced with function
Is there something in the linter that's requiring that?
There was a problem hiding this comment.
Yes, this is due to satisfaction of an automatically fixable react/function-component-definition rule. You can find more details on the rule here.
…g into bilalqamar95/frontend-build-upgrade
|
@BilalQamar95, we'd like to merge this, but there are conflicts with master. Do you mind squashing/rebasing manually? |
|
Never mind, we can do Squash and merge, apparently :) |
Ticket:
42: Upgrade eslint to v8.x
What changed?
frontend-buildto v12 (Eslint was updated infrontend-buildversion resulting in it's version being bumped to v12. This PR updatesfrontend-buildto reciprocate eslint version update)eslintissues post update