Paragon form component deprecations #53
Conversation
…rnate in LibraryCreateForm
…rnate in LibraryConfigurePage
…rnate in LibraryAccessForm
…g into abdullahwaheed/paragon-form-deprecations
Codecov ReportBase: 49.06% // Head: 49.07% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
=======================================
Coverage 49.06% 49.07%
=======================================
Files 76 76
Lines 1985 1997 +12
Branches 366 373 +7
=======================================
+ Hits 974 980 +6
- Misses 977 983 +6
Partials 34 34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…g into abdullahwaheed/paragon-form-deprecations
…g into abdullahwaheed/paragon-form-deprecations
| const renderOption = option => { | ||
| if (option.group) { | ||
| return ( | ||
| <optgroup label={option.label}> | ||
| {option.group.map(renderOption)} | ||
| </optgroup> | ||
| ); | ||
| } | ||
| return ( | ||
| <option value={option.value} key={option.value}>{option.label}</option> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
i noticed there is an identical function in LibraryListPage.jsx, is there any way this could be put somewhere that allows it to be used in both files?
There was a problem hiding this comment.
renderOption isn't used in LibraryListPage.jsx anymore so I have removed it. Don't think we should make it a util now
abdullahwaheed
added
waiting on author
…g into abdullahwaheed/paragon-form-deprecations
abdullahwaheed
removed
the
waiting on author
Ticket
Migrate off deprecated Paragon components
What has changed
Updated deprecated
ValidationFormGrouptoForm.Group,InputtoForm.ControlandCheckboxtoForm. CheckBox.Tested on openedx theme as well.