-
Notifications
You must be signed in to change notification settings - Fork 25
Conversation
Codecov ReportBase: 49.12% // Head: 49.12% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #73 +/- ##
=======================================
Coverage 49.12% 49.12%
=======================================
Files 76 76
Lines 2003 2003
Branches 372 372
=======================================
Hits 984 984
Misses 985 985
Partials 34 34 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concern is that using testeng-ci breaks Rule #2 here.
"Repos must be added to the openedx org before they become critical dependencies of any other repository in the openedx organization."
Not sure how critical I'd classify the automatic browserlist update, but as I note below, my gut feeling is that we'd want the (a?) PR creator in the openedx org itself.
(We can discuss this in the next Frontend Working Group meeting, too.)
|
||
- name: setup testeng-ci | ||
run: | | ||
git clone https://github.com/edx/testeng-ci.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this PR creator is something that would be widely useful to the Open edX community. (I mean, it's already going into all MFEs. :) Would it be possible for us to get in touch with the maintainer of the testeng-ci
repository, and then to consider copying the relevant bits into the openedx org?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about this, @jmbowman can comment on this
Alright, I'm up for merging this. @abdullahwaheed, mind rebasing? |
@arbrandes we are moving towards using this create-pull-request package, so let me update this PR accordingly and then we can merge. Please refer to this thread for details |
…g into abdullahwaheed/auto-update-browserlist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, and repo auto-merge set.
Ticket
Automate browserslist DB update
What has changed
Added a Github workflow that would run periodically(weekly), update browserslist DB, create a PR and merge it automatically.
Used a shared workflow for this