Skip to content
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.

feat: auto update browserslist DB #73

Merged
merged 3 commits into from
Dec 21, 2022

Conversation

abdullahwaheed
Copy link
Contributor

@abdullahwaheed abdullahwaheed commented Oct 6, 2022

Ticket

Automate browserslist DB update

What has changed

Added a Github workflow that would run periodically(weekly), update browserslist DB, create a PR and merge it automatically.
Used a shared workflow for this

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 49.12% // Head: 49.12% // No change to project coverage 👍

Coverage data is based on head (f9d8731) compared to base (26ea285).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   49.12%   49.12%           
=======================================
  Files          76       76           
  Lines        2003     2003           
  Branches      372      372           
=======================================
  Hits          984      984           
  Misses        985      985           
  Partials       34       34           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern is that using testeng-ci breaks Rule #2 here.

"Repos must be added to the openedx org before they become critical dependencies of any other repository in the openedx organization."

Not sure how critical I'd classify the automatic browserlist update, but as I note below, my gut feeling is that we'd want the (a?) PR creator in the openedx org itself.

(We can discuss this in the next Frontend Working Group meeting, too.)


- name: setup testeng-ci
run: |
git clone https://github.com/edx/testeng-ci.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this PR creator is something that would be widely useful to the Open edX community. (I mean, it's already going into all MFEs. :) Would it be possible for us to get in touch with the maintainer of the testeng-ci repository, and then to consider copying the relevant bits into the openedx org?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this, @jmbowman can comment on this

@arbrandes
Copy link
Contributor

Alright, I'm up for merging this. @abdullahwaheed, mind rebasing?

@abdullahwaheed
Copy link
Contributor Author

Alright, I'm up for merging this. @abdullahwaheed, mind rebasing?

@arbrandes we are moving towards using this create-pull-request package, so let me update this PR accordingly and then we can merge.

Please refer to this thread for details

@jmbowman jmbowman added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Dec 9, 2022
@abdullahwaheed abdullahwaheed marked this pull request as draft December 12, 2022 13:41
@abdullahwaheed abdullahwaheed removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Dec 20, 2022
@abdullahwaheed abdullahwaheed marked this pull request as ready for review December 20, 2022 18:20
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, and repo auto-merge set.

@arbrandes arbrandes changed the title Automate Browserlist DB Update feat: auto update browserslist DB Dec 21, 2022
@arbrandes arbrandes merged commit 529c759 into master Dec 21, 2022
@arbrandes arbrandes deleted the abdullahwaheed/auto-update-browserlist branch December 21, 2022 21:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants