Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Conversation

regisb
Copy link

@regisb regisb commented Dec 5, 2023

Description

Backport #813

Without this change, building the payment MFE fails during npm ci with the following error:

> [payment-common 3/5] RUN --mount=type=cache,target=/root/.npm,sharing=shared npm clean-install --no-audit --no-fund --registry=https://registry.npmjs.org/:                                                     
7.939 npm ERR! code EUSAGE                                                                                                                                                                                         
7.950 npm ERR!                                                                                                                                                                                                     
7.952 npm ERR! `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.              
7.952 npm ERR!                                                                                                                                                                                                     
7.952 npm ERR! Invalid: lock file's @babel/types@7.22.5 does not satisfy @babel/types@7.23.5                                                                                                                       
7.952 npm ERR! Invalid: lock file's @babel/template@7.22.5 does not satisfy @babel/template@7.22.15                                                                                                                
7.952 npm ERR! Invalid: lock file's @babel/code-frame@7.22.5 does not satisfy @babel/code-frame@7.23.5                                                                                                             
7.952 npm ERR! Invalid: lock file's @babel/parser@7.22.5 does not satisfy @babel/parser@7.23.5                                                                                                                     
7.952 npm ERR! Invalid: lock file's @babel/highlight@7.22.5 does not satisfy @babel/highlight@7.23.4                                                                                                               
7.952 npm ERR! Invalid: lock file's @babel/helper-validator-identifier@7.22.5 does not satisfy @babel/helper-validator-identifier@7.22.20                                                                          
7.953 npm ERR! Invalid: lock file's @babel/helper-environment-visitor@7.22.5 does not satisfy @babel/helper-environment-visitor@7.22.20                                                                            
7.953 npm ERR! Invalid: lock file's @babel/helper-split-export-declaration@7.22.5 does not satisfy @babel/helper-split-export-declaration@7.22.6                                                                   
7.953 npm ERR! Invalid: lock file's @babel/helper-string-parser@7.22.5 does not satisfy @babel/helper-string-parser@7.23.4                                                                                         
7.953 npm ERR!                                                                                                                                                                                                     
7.953 npm ERR! Clean install a project                                                                                                                                                                             
7.953 npm ERR!                                                                                           
7.954 npm ERR! Usage:                                                                                    
7.954 npm ERR! npm ci                                                                                    
7.954 npm ERR!                                                                                           
7.954 npm ERR! Options:                                                                                                                                                                                            
7.954 npm ERR! [-S|--save|--no-save|--save-prod|--save-dev|--save-optional|--save-peer|--save-bundle]    
7.954 npm ERR! [-E|--save-exact] [-g|--global]                                                           
7.954 npm ERR! [--install-strategy <hoisted|nested|shallow|linked>] [--legacy-bundling]                                                                                                                            
7.954 npm ERR! [--global-style] [--omit <dev|optional|peer> [--omit <dev|optional|peer> ...]]            
7.954 npm ERR! [--strict-peer-deps] [--no-package-lock] [--foreground-scripts]                           
7.954 npm ERR! [--ignore-scripts] [--no-audit] [--no-bin-links] [--no-fund] [--dry-run]                                                                                                                            
7.954 npm ERR! [-w|--workspace <workspace-name> [-w|--workspace <workspace-name> ...]]                                                                                                                             
7.954 npm ERR! [-ws|--workspaces] [--include-workspace-root] [--install-links]                                                                                                                                     
7.954 npm ERR!                                                                                                                                                                                                     
7.954 npm ERR! aliases: clean-install, ic, install-clean, isntall-clean                                                                                                                                            
7.954 npm ERR!                                                                                                                                                                                                     7.954 npm ERR! Run "npm help ci" for more info                                                                                                                                                                     
7.958                                                                                                                                                                                                              
7.958 npm ERR! A complete log of this run can be found in:                                                                                                                                                         
7.958 npm ERR!     /root/.npm/_logs/2023-12-05T09_02_32_335Z-debug-0.log                                                                                                                                           
------                                                                                                                                                                                                             
Dockerfile:686                                                                                                                                                                                                     
--------------------                                                                                                                                                                                               
 684 |     ENV CPPFLAGS=-DPNG_ARM_NEON_OPT=0                                                                                                                                                                       
 685 |     ENV PACT_SKIP_BINARY_INSTALL=true                                                                                                                                                                       
 686 | >>> RUN --mount=type=cache,target=/root/.npm,sharing=shared npm clean-install --no-audit --no-fund --registry=$NPM_REGISTRY                                                                                 
 687 |                                                                                                                                                                                                             
 688 |                                                                                                                                                                                                             
--------------------                                                                                                                                                                                               
ERROR: failed to solve: process "/bin/sh -c npm clean-install --no-audit --no-fund --registry=$NPM_REGISTRY" did not complete successfully: exit code: 1       

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 5, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @regisb! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@abdullahwaheed
Copy link
Contributor

Hi @regisb could you please cherry-pick this commit or allow me to push changes in your branch

* fix: fixed @adobe/css-tools vulnerability

* refactor: whitelisted axios vulnerability since we'll upgrade it separately

* fix: fixed integrity issue
@regisb
Copy link
Author

regisb commented Dec 6, 2023

@abdullahwaheed done. Thanks for the tip!

Copy link
Contributor

@zubair-ce07 zubair-ce07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zubair-ce07 zubair-ce07 merged commit 40ef3bd into openedx-unsupported:open-release/quince.master Dec 7, 2023
4 checks passed
@openedx-webhooks
Copy link

@regisb 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants