Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

chore: add catalog info #620

Conversation

ichintanjoshi
Copy link
Contributor

Description

  • added catalog-info.yaml
  • changed github issue template file

@openedx-webhooks
Copy link

Thanks for the pull request, @ichintanjoshi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 29, 2024
Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ichintanjoshi - looks like there's some yaml linting errors on the catalog-info. You should check those, and make sure any errors are corrected on other PRs.

catalog-info.yaml Outdated Show resolved Hide resolved
@ichintanjoshi
Copy link
Contributor Author

@ichintanjoshi - looks like there's some yaml linting errors on the catalog-info. You should check those, and make sure any errors are corrected on other PRs.

Yes @sarina on it

@ichintanjoshi
Copy link
Contributor Author

Updated linting @sarina

@sarina
Copy link
Contributor

sarina commented May 30, 2024

hey @ichintanjoshi I am waiting in #621 as well as in #dev in slack to get an answer on whether or not we can decrease the codecov threshold (or scrap codecov altogether), I'll merge this when I have a solution.

Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ichintanjoshi - I can't seem to edit your branch. Could you do the following, then I will merge?

  • Rebase the branch on master
  • Squash to two commits (chore: add catalog-info.yml and chore: enable github issues via config file)

@mphilbrick211
Copy link

@sarina @ichintanjoshi - just following up on this.

@ichintanjoshi
Copy link
Contributor Author

@sarina @ichintanjoshi - just following up on this.

@sarina Have rebased

@sarina
Copy link
Contributor

sarina commented Jun 14, 2024

@ichintanjoshi can you address this feedback from my last comment?

Squash to two commits (chore: add catalog-info.yml and chore: enable github issues via config file)

This will require an interactive rebase, not merging master into this branch.

@sarina
Copy link
Contributor

sarina commented Jun 14, 2024

You will need to run

git rebase -i HEAD~8

to get at the comments in your branch, and then use the commands in interactive rebase to move and squash commits. We follow a rebasing workflow so it is wise to get used to actually rebasing rather than merging in master. I can only squash your commits down to one commit via the GitHub UI, and I want to maintain the two different changes made in this branch. https://hackernoon.com/beginners-guide-to-interactive-rebasing-346a3f9c3a6d

Alternatively, you can close this PR and make a new one with the changes properly separated out, although I think that's more work.

chore: Updating Python Requirements (openedx-unsupported#617)

chore: add catalog-info.yml

chore: enable github issues via config file

fix: change linting for catalog-info.yaml file

docs: Update README

* Remove outdated Travis CI badge
* s/edX/Open edX/
* Add note about Tutor - currently unknown if this package works on Tutor, but Devstack is deprecated.

chore: Drop codecov to 90, which is a sane amount
@openedx-webhooks
Copy link

@ichintanjoshi Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@ichintanjoshi ichintanjoshi deleted the add-catalog-info branch June 20, 2024 12:50
@ichintanjoshi
Copy link
Contributor Author

@sarina closing this as I think I messed up the rebasing part, will raise a new one

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants