Python Requirements Update #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarina
reviewed
Jun 23, 2021
| # via -r requirements/pip_tools.in | ||
| toml==0.10.2 | ||
| # via pep517 | ||
| wheel==0.36.2 |
There was a problem hiding this comment.
@Jawayria I think you might know, why is this adding wheel?
There was a problem hiding this comment.
@sarina We're getting them indirectly via pip-tools (as indicated in the requirements comment below).
pip, setuptools and wheel are runtime dependencies that should
be explicitly included. If not, they may not be provided on
systems which install packages pre-built, thus these packages
should not be assumed to be installed.
XBlock txt requirements are not used in production, so there shouldn't be any risk, regardless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python requirements update.Please review the changelogs for the upgraded packages.