Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup test dependencies #133

Merged
merged 6 commits into from
Apr 25, 2023
Merged

Cleanup test dependencies #133

merged 6 commits into from
Apr 25, 2023

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Apr 24, 2023

We remove pycodestyle and mock both of which are not necessary for
different reasons.

Closes #131

  • style: Remove pycodestyle.
  • build: Update tox config for the latest version of tox.
  • chore: Run make upgrade
  • build: Update pylintrc from edx-lint.
  • test: Remove explicit mock requirement.
  • chore: Run make upgrade

Feanil Patel added 6 commits April 24, 2023 15:39
It's redundant with pylint.
`whiteliste_externals` has been replaced with `allowlist_externals`.
This silences a warning during tox runs.
`mock` is in the standard library now we don't need to require the old
package.
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f363857) 56.36% compared to head (4c8fd33) 56.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   56.36%   56.36%           
=======================================
  Files           3        3           
  Lines          55       55           
=======================================
  Hits           31       31           
  Misses         24       24           
Flag Coverage Δ
unittests 56.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@feanil feanil marked this pull request as ready for review April 24, 2023 19:53
@feanil feanil requested review from e0d and ormsbee April 24, 2023 19:53
Copy link
Contributor

@e0d e0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@feanil feanil merged commit c0ac013 into master Apr 25, 2023
@feanil feanil deleted the feanil/remove_pycodestyle branch April 25, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove pycodestyle
2 participants