Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upgrade to Django 4.2 #152

Merged
merged 8 commits into from
Jul 21, 2023
Merged

feat: Upgrade to Django 4.2 #152

merged 8 commits into from
Jul 21, 2023

Conversation

zubairshakoorarbisoft
Copy link
Contributor

@zubairshakoorarbisoft zubairshakoorarbisoft commented Jul 17, 2023 •
edited
Loading

Issue: edx/upgrades#137
Upgrade to Django 4.2

@codecov
Copy link

codecov bot commented Jul 17, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (708dcb2) 56.36% compared to head (c0786a9) 56.36%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   56.36%   56.36%           
=======================================
  Files           3        3           
  Lines          55       55           
=======================================
  Hits           31       31           
  Misses         24       24
Flag Coverage Δ
unittests 56.36% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
done/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

feanil
feanil reviewed Jul 18, 2023
View reviewed changes
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a version bump as well so that we can release the new version that supports django 4.2?

@github-actions github-actions bot mentioned this pull request Jul 20, 2023
Closed
@e0d e0d added product review PR requires product review before merging waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Jul 20, 2023
@github-actions github-actions bot mentioned this pull request Jul 20, 2023
Closed
@zubairshakoorarbisoft
Copy link
Contributor Author

Should there be a version bump as well so that we can release the new version that supports django 4.2?

sure

@zubairshakoorarbisoft zubairshakoorarbisoft merged commit 9101f41 into master Jul 21, 2023
@zubairshakoorarbisoft zubairshakoorarbisoft deleted the zshkoor/django42 branch July 21, 2023 14:24
@zubairshakoorarbisoft zubairshakoorarbisoft changed the title feat: upgrade to Django 4.2 feat: Upgrade to Django 4.2 Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feanil feanil feanil left review comments

@mumarkhan999 mumarkhan999 mumarkhan999 approved these changes

@UsamaSadiq UsamaSadiq Awaiting requested review from UsamaSadiq

Assignees
No one assigned
Labels
product review PR requires product review before merging waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zubairshakoorarbisoft @feanil @mumarkhan999 @e0d @awais786 @edx-requirements-bot