Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how we do common constraintst #48

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Fix how we do common constraintst #48

merged 2 commits into from
Jun 23, 2022

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Jun 21, 2022

No description provided.

@feanil
Copy link
Contributor Author

feanil commented Jun 21, 2022

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #48 (8e0d84a) into master (f220d8c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   50.98%   50.98%           
=======================================
  Files           3        3           
  Lines          51       51           
=======================================
  Hits           26       26           
  Misses         25       25           
Flag Coverage Δ
unittests 50.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f220d8c...8e0d84a. Read the comment docs.

@feanil feanil requested a review from e0d June 21, 2022 21:42
Copy link
Contributor

@e0d e0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise looks good.

requirements/constraints.txt Outdated Show resolved Hide resolved
Feanil Patel added 2 commits June 23, 2022 09:49
It's not clear why this file was originally added to this repo but we
should be referencing the version in edx-lint unless we have a good
reason not to do so.  Currently this is the pattern being followed in
other repos(edx-rest-api-client, XBlock, edx-django-utils, etc) so
treating that as best-practice for now.
@feanil feanil force-pushed the feanil/fix_pip_routing branch from e08f806 to 8e0d84a Compare June 23, 2022 13:49
@feanil feanil merged commit d7f604a into master Jun 23, 2022
@feanil feanil deleted the feanil/fix_pip_routing branch June 23, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants