fix: remove required reviewer from pr template#145
Merged
Conversation
Remove `@edx/arch-review` from the list of required reviewers. I added the PR template as part of adding a changelog 2 years ago, and I don't see any reason to also have added a new review requirement, namely `@edx/arch-review`. It is possible this was just copy/pasted. Most contributors are already accustomed to asking owners for review when and if there is any significant change that requires review. This change simplifies the process for simple changes by not implying that arch-review (which is not actually the owner anyway) needs to review.
timmc-edx
approved these changes
Nov 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
@edx/arch-reviewfrom the list of required reviewers.I added the PR template as part of adding a changelog 2 years ago,
and I don't see any reason to also have added a new review requirement,
namely
@edx/arch-review. It is possible this was just copy/pasted.Most contributors are already accustomed to asking owners for review
when and if there is any significant change that requires review. This
change simplifies the process for simple changes by not implying that
arch-review (which is not actually the owner anyway) needs to review.
Description:
Describe in a couple of sentences what this PR adds
JIRA:
XXX-XXXX
Additional Details
Reviewers:
Merge checklist:
Post merge:
finished.