Skip to content

[GH Request] Ensure that write access is granted only for CCs and FCs #1511

@kdmccormick

Description

@kdmccormick

Firm Name

Axim

Urgency

High (< 3 days)

Requested Change

  • Remove all remaining write access from 2u-* teams.
  • For teams which are listed in edx-platform CODEOWNERS, create a new team named committers-edx-platform-2u-$TEAM. Add the engineers from $TEAM who are edx-platform CCs. Grant edx-platform write access.
  • Delete all CODEOWNERS files other than edx-platform's. Inform the team that was listed that they should instead subscribe to new PRs on the repository.

Reasoning

New engineers are joining teams at 2U. 2U would like these engineers to be members of their corresponding GitHub teams, like 2u-tnl. Example request.

However, the new engineers cannot be added to teams which grant write access until they fulfill the requirement of the Core Contributor program and then have their access rights nominated and confirmed by community vote.

Currently, some of the 2u- teams grant write access as a prerequisite to being listed in CODEOWNERS, which ensures that they get notified when certain files are changed. See edx-platform CODEOWNERS.

By removing access from 2u-* teams, we are able to add the engineers to those teams. By creating committers-edx-platform-2u-*, we allow the subsets of those teams with edx-platform CC rights to receive notifications on the PRs they're interested in. This simplifies our access structure scheme which makes it less likely that we'll get confused and incorrectly grant or revoke access.

Metadata

Metadata

Assignees

Labels

github-requestRequest for change to access level or settings in the openedx GitHub organization.

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions