feat: Upgrade to codejail 4 #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmc-edx
force-pushed
the
timmc/cj4
branch
2 times, most recently
from
e2dab60 to
c246824
Compare
This brings an important security improvement (although codejail-service has other protections against misconfigured codejail.) It is now also safe to import `codejail.safe_exec` at any time, rather than having to delay it until after configuration has happened. Our safe_exec wrapper can now be simplified a bit as a result. Also, add missing `super.tearDown()` in a test class.
dianakhuang
approved these changes
Jun 17, 2025
robrap
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings an important security improvement (although codejail-service has other protections against misconfigured codejail.)
It is now also safe to import
codejail.safe_execat any time, rather than having to delay it until after configuration has happened. Our safe_exec wrapper can now be simplified a bit as a result.Also, add missing
super.tearDown()in a test class.Merge checklist:
Check off if complete or not applicable:
Post-merge: