Fix quality violations; enable quality checks via tox/make#99
Merged
kdmccormick merged 1 commit intomasterfrom Nov 3, 2020
Merged
Fix quality violations; enable quality checks via tox/make#99kdmccormick merged 1 commit intomasterfrom
kdmccormick merged 1 commit intomasterfrom
Conversation
kdmccormick
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#98 involves refactoring several files. It'd be helpful to be able to use pylint to catch anything I miss in that refactoring.
This cleans up all of the quality violations in codejail and adds a
make qualitytarget, which runs pycodestyle, isort, and pylint on all python files in the repo.This Jenkins DSL PR would enable quality checking on new CodeJail PRs: edx/jenkins-job-dsl#1166