Skip to content

Commit

Permalink
build: Upgrade to Node 20 (#847)
Browse files Browse the repository at this point in the history
* feat: updated node to v20, update ci workflow

* feat: added lockfile version check workflow
  • Loading branch information
BilalQamar95 authored Sep 6, 2024
1 parent b83dbcb commit ba51fbd
Show file tree
Hide file tree
Showing 4 changed files with 38 additions and 2,840 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ jobs:
python-version: ['3.8', '3.12']
django-version: ['4.2']
node: [18, 20]
continue-on-error: ${{ matrix.node == 20 }}
steps:
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
Expand All @@ -24,7 +23,7 @@ jobs:
- name: Setup Nodejs
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
node-version: ${{ env.NODE_VER }}

- name: run tests with Django ${{ matrix.django-version }}
run: |
Expand Down
13 changes: 13 additions & 0 deletions .github/workflows/lockfileversion-check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
#check package-lock file version

name: Lockfile Version check

on:
push:
branches:
- master
pull_request:

jobs:
version-check:
uses: openedx/.github/.github/workflows/lockfileversion-check-v3.yml@master
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
20
Loading

0 comments on commit ba51fbd

Please sign in to comment.