Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp: omit publicPath from webpack.config.js #1944

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

justinhynes
Copy link
Contributor

@justinhynes justinhynes commented Feb 23, 2023

Temporary change that is a test fix for APER-2210. I read that if publicPath is set in a webpack config then django-webpack-loader will use publicPath over the static URL settings. I think this could be the source of the problem with some of our assets being accessed at an incorrect URL.

I'm making this change based on a conversation here: django-webpack/django-webpack-loader#107, specifically:

@mik3y Preferring publicPath over django's storage is a feature and the only way to give preference to django's storage right now is to omit publicPath from your webpack config like you correctly pointed out.

Temporary change that is a test fix for APER-2210. I read that if `publicPath` is set in a webpack config then `django-webpack-loader` will use `publicPath` over the static URL settings. I think this could be the source of the problem with some of our assets being accessed at an incorrect URL.
@justinhynes justinhynes merged commit 140155f into master Feb 23, 2023
@justinhynes justinhynes deleted the jhynes/aper-2210_404 branch February 23, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants