feat: the signatory is not mandatory on coursecertificate configurations #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry on coursecertificates Credentials IDA requires signatories on `ProgramCertificate` configurations. However, on `CourseCertificate` configurations, not all sites will care if a signatory is present. The certificates themselves don't render in the credentials IDA, and this is cloned data from the system of record. Although this has always been nullable in the ORM because of the way django handles nullability for `ManyToManyField`, the django admin enforces the presence of a signatory. This keeps the signatory required for `ProgramCertificate`, but makes it blankable for `CourseCertificate`. FIXES: APER-3494
jsnwesson
reviewed
Jul 9, 2024
Co-authored-by: Jason Wesson <jsnwesson@gmail.com>
justinhynes
reviewed
Jul 10, 2024
| """ | ||
| a CourseCertificate configuration without a signatory passes validation | ||
| """ | ||
| expected = 302 |
There was a problem hiding this comment.
Curious as to why we expect a 302. Just a function of how the call works after saving an entry? A redirect to the list of course cert configs in Django admin?
Also, I know the method for saving is different than the Program cert test, but would it be easier/better to check that the admin form has no errors?
There was a problem hiding this comment.
apparently saving successfully gives a redirect to the list page, I verified this is normal and expected in both reality and django tests.
justinhynes
approved these changes
Jul 10, 2024
deborahgu
deleted the
dkaplan1/APER-3494_credentials-has-a-coursecertificate-signatory-field-and-shouldnt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credentials IDA requires signatories on
ProgramCertificateconfigurations. However, onCourseCertificateconfigurations, not all sites will care if a signatory is present. The certificates themselves don't render in the credentials IDA, and this is cloned data from the system of record. Although this has always been nullable in the ORM because of the way django handles nullability forManyToManyField, the django admin enforces the presence of a signatory.This keeps the signatory required for
ProgramCertificate, but makes it blankable forCourseCertificate.FIXES: APER-3494
Run JavaScript tests locally with Karma
There is work being done on a fix to get Karma to run in CI. Until then, however, contributors are required to run these tests locally.
make test-karma