fix: sql_require_primary_key compatibility #116
Conversation
In MySQL, if the `sql_require_primary_key` is turned on, no table can exist without a primary key. Since the migration 0005 drops the primary key field before model deletion, the table misses the primary key, hence the migration will fail. To prevent migration failure, we swap the primary key before dropping the `revisionpluginrevision_ptr` field which is the actual primary key. In case the migration need to be reverted, the opposite will happen and we set the `revisionpluginrevision_ptr` as the primary key. When selecting the new primary key, it doesn't really matter what we set, since at the end of the migration we drop the whole table. Signed-off-by: Gabor Boros <gabor.brs@gmail.com>
openedx-webhooks
added
needs triage
open-source-contribution
|
Thanks for the pull request, @gabor-boros! I've created OSPR-6603 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
@natabene who should be contacted for a review here? 😊 |
|
@gabor-boros Thank you for your contribution. @jmyatt Could you review this OSPR when you have a chance? |
|
@UsamaSadiq may could help out too with reviewing 😊 |
|
@gabor-boros I'll prioritise it for review within the team soon. Thanks for the PR. |
|
Thank you @UsamaSadiq! |
There was a problem hiding this comment.
@gabor-boros thanks for your patience. I'll go ahead and merge this PR as well.
|
@UsamaSadiq Excited about this merge. |
|
@gabor-boros 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
In MySQL, if the
sql_require_primary_keyis turned on, no table canexist without a primary key. Since the migration 0005 drops the primary
key field before model deletion, the table misses the primary key, hence
the migration will fail.
To prevent migration failure, we swap the primary key before dropping
the
revisionpluginrevision_ptrfield which is the actual primary key.In case the migration need to be reverted, the opposite will happen and
we set the
revisionpluginrevision_ptras the primary key.When selecting the new primary key, it doesn't really matter what we
set, since at the end of the migration we drop the whole table.
Signed-off-by: Gabor Boros gabor.brs@gmail.com