-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FC-0068: Adding and converting txt files into rst format #699
base: main
Are you sure you want to change the base?
Conversation
adding and cleaning up for create_unit.rst
Thanks for the pull request, @jesgreco! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have "duplicate label" warnings in your build. They are coming because we already have "create a section", "create a subsection", and "create a unit" targets.
So the question becomes where you got these instructions from? I think you got them from the old .txt files, and didn't write this anew?
In that case, the short term fix might be to give these unique target names. But please bring this up in your next meeting, because this is a scenario where we have two very overlapping how-tos, and we should fix that together.
@jswope00 ok! I'll write this in our channel to see if we can have a solution before the next meeting which will be 8th January. |
@jswope00 I've solved the conflict for merging but, still we need to solve the label duplication. |
1 similar comment
@jswope00 I've solved the conflict for merging but, still we need to solve the label duplication. |
adding and cleaning up for create_unit.rst