Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FC-0068: Reference cleaning by edunext #5 #700

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Apgomeznext
Copy link
Contributor

@Apgomeznext Apgomeznext commented Dec 19, 2024

This PR modifies a series of reference documents migrated from the legacy repositories to the educators' documentation. The principal changes were in the erased checkbox document, and the Oppia exploration document was divided into a reference and a how-to, as also happened with create_exercises_and_tools.

Also, the document create_exercises_and_tools has a link to an edX repository file about Levels Support that is not in the Open edX repository.

This PR modifies a series of reference documents migrated from the legacy repositories to the educators' documentation.
The principal changes were in the erased checkbox document, and the Oppia exploration document was divided into a reference and a how-to.

Also, the document create_exercises_and_tools has a link to an edX repository file about Levels Support that is not in the Open edX repository.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 19, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Dec 19, 2024

Thanks for the pull request, @Apgomeznext!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/docs-openedx-org-maintainers. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@Apgomeznext Apgomeznext marked this pull request as ready for review December 20, 2024 03:00
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Dec 20, 2024
@@ -66,7 +66,7 @@ types** or select Advanced problem types for a list of **advanced problem types*
Options for scoring, hints, feedback and more can be entered.

* For advanced problem types, the :ref:`advanced editor<Advanced Editor>` opens.
In this editor you use `EdX Open Learning XML Guide`_.
In this editor you use :ref:`Set Up Group Configuration for OLX Courses`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't moved OLX yet. So it looks like what was done here is you've linked to one of the few files that do mention OLX. But you are pointing specifically to group configuration, not generic OLX intro.

We should just link to the legacy link in this case, since it is easy to track that error .

You've reminded me that I have this old issue assigned to me. I'll add a note to this issue to take care of this link once OLX is moved: #495

So, in summary, revert this back to the EdX Open Learning XML Guide_ link

Copy link
Contributor Author

@Apgomeznext Apgomeznext Dec 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link has been reverted to the legacy link.

Thanks for the review and the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Status: In Eng Review
Development

Successfully merging this pull request may close these issues.

4 participants