-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FC-0068: Reference cleaning by edunext #5 #700
base: main
Are you sure you want to change the base?
FC-0068: Reference cleaning by edunext #5 #700
Conversation
This PR modifies a series of reference documents migrated from the legacy repositories to the educators' documentation. The principal changes were in the erased checkbox document, and the Oppia exploration document was divided into a reference and a how-to. Also, the document create_exercises_and_tools has a link to an edX repository file about Levels Support that is not in the Open edX repository.
Thanks for the pull request, @Apgomeznext! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@@ -66,7 +66,7 @@ types** or select Advanced problem types for a list of **advanced problem types* | |||
Options for scoring, hints, feedback and more can be entered. | |||
|
|||
* For advanced problem types, the :ref:`advanced editor<Advanced Editor>` opens. | |||
In this editor you use `EdX Open Learning XML Guide`_. | |||
In this editor you use :ref:`Set Up Group Configuration for OLX Courses`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't moved OLX yet. So it looks like what was done here is you've linked to one of the few files that do mention OLX. But you are pointing specifically to group configuration, not generic OLX intro.
We should just link to the legacy link in this case, since it is easy to track that error .
You've reminded me that I have this old issue assigned to me. I'll add a note to this issue to take care of this link once OLX is moved: #495
So, in summary, revert this back to the EdX Open Learning XML Guide
_ link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link has been reverted to the legacy link.
Thanks for the review and the clarification.
This PR modifies a series of reference documents migrated from the legacy repositories to the educators' documentation. The principal changes were in the erased checkbox document, and the Oppia exploration document was divided into a reference and a how-to, as also happened with create_exercises_and_tools.
Also, the document create_exercises_and_tools has a link to an edX repository file about Levels Support that is not in the Open edX repository.