-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding see also tables #709
base: main
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @jesgreco! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@jesgreco can you also add /references/testing_course_content.rst to the See Also section? The rule of thumb is that see also sections should at least include any of the docs that are in the same navigation section as the doc that is being read. In this case, navigation to roles_for_viewing.rst lives in educators/navigation/content_creation_management.rst |
creating_course.rst course_pacing.rst resources_for_course_teams.rst
setting_course_pacing.rst scheduling_course.rst
…learners_profile.rst files
@jesgreco This PR has a conflict with the main branch. Looks to me like the conflict is in the resources_for_course_teams.rst file. In the main branch, that file has a full set of "seealso" links. In your PR, there is only one or two. So, you'll need to merge the remote main branch into your working branch, and fix the conflict by using the main's version of resources_for_course_teams.rst, and then try your PR again. Alernatively, I think you could just undo all your changes in resources_for_course_teams.rst and then the PR will pass with no conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the conflict (see my comment in the thread) and then re-request a PR
@jswope00 conflicts were solved and also changes requested were made. |
adding see also table for roles_for_viewing.rst