Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add implementation for set_monitoring_transaction_name in DD. #457

Merged
merged 1 commit into from
Oct 15, 2024
Merged

feat: Add implementation for set_monitoring_transaction_name in DD. #457

merged 1 commit into from
Oct 15, 2024

Conversation

dianakhuang
Copy link
Contributor

@dianakhuang dianakhuang commented Oct 15, 2024 •
edited
Loading

This also refactors the existing NewRelic implementation to use the backends framework.

Also added comments about not porting ignore_transactions. This way of ignoring spans is not supported by Datadog.

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPi after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

@dianakhuang dianakhuang force-pushed the diana/refactor-monitoring branch from 3f1872e to 7fe4bbb Compare October 15, 2024 15:41
@dianakhuang dianakhuang force-pushed the diana/refactor-monitoring branch 4 times, most recently from aedd47c to 3565015 Compare October 15, 2024 16:22
timmc-edx
timmc-edx reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@timmc-edx timmc-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions on docs, and a question or two.

edx_django_utils/monitoring/README.rst Outdated Show resolved Hide resolved
edx_django_utils/monitoring/internal/backends.py Outdated Show resolved Hide resolved
edx_django_utils/monitoring/internal/backends.py Outdated Show resolved Hide resolved
edx_django_utils/monitoring/internal/utils.py Outdated Show resolved Hide resolved
@dianakhuang dianakhuang force-pushed the diana/refactor-monitoring branch from 186e6c0 to 8ec820f Compare October 15, 2024 16:40
@dianakhuang
feat: Add implementation for set_monitoring_transaction_name in DD.
4e893ef 
This also refactors the existing NewRelic implementation to use the
backends framework.

Also added comments about not porting ignore_transactions. This way of
ignoring spans is not supported by Datadog.
@dianakhuang dianakhuang force-pushed the diana/refactor-monitoring branch from 8ec820f to 4e893ef Compare October 15, 2024 17:02
@dianakhuang dianakhuang merged commit 2d7519c into master Oct 15, 2024
5 of 7 checks passed
@dianakhuang dianakhuang deleted the diana/refactor-monitoring branch October 15, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmc-edx timmc-edx timmc-edx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dianakhuang @timmc-edx