Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add issuer monitoring #325

Merged
merged 3 commits into from
Apr 12, 2023
Merged

feat: add issuer monitoring #325

merged 3 commits into from
Apr 12, 2023

Conversation

robrap
Copy link
Contributor

@robrap robrap commented Apr 11, 2023

Description:

Add new custom attributes to verify how the issuer is being verified at this time.
Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bump if needed
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPi after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

robrap added 2 commits April 12, 2023 14:59
Add new custom attributes to verify how the issuer
is being verified at this time.
@robrap robrap force-pushed the robrap/monitor-issuer-check branch from 6a90420 to d2a60b4 Compare April 12, 2023 19:03
Copy link

@HacDmv HacDmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

@robrap robrap merged commit ae7416f into master Apr 12, 2023
@robrap robrap deleted the robrap/monitor-issuer-check branch April 12, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants