Merge pull request #1913 from openedx/asheehan-edx/sso-orchestrator-e…

…xception-handling

chore: orchestrator exception handling and submission refinements

CHANGELOG.rst

@@ -15,6 +15,10 @@ Change Log
 
 Unreleased
 ----------
+[4.6.6]
+-------
+chore: orchestrator exception handling and submission refinements
+
 [4.6.5]
 -------
 feat: Added logs for Degreed2 client

enterprise/__init__.py

@@ -2,4 +2,4 @@
 Your project description goes here.
 """
 
-__version__ = "4.6.5"
+__version__ = "4.6.6"

enterprise/api/v1/views/enterprise_customer_sso_configuration.py

@@ -322,7 +322,7 @@ def update(self, request, *args, **kwargs):
             with transaction.atomic():
                 sso_configuration_record.update(**request_data)
                 sso_configuration_record.first().submit_for_configuration(updating_existing_record=True)
-        except (TypeError, FieldDoesNotExist, ValidationError) as e:
+        except (TypeError, FieldDoesNotExist, ValidationError, SsoOrchestratorClientError) as e:
             LOGGER.error(f'{CONFIG_UPDATE_ERROR}{e}')
             return Response({'error': f'{CONFIG_UPDATE_ERROR}{e}'}, status=HTTP_400_BAD_REQUEST)
         serializer = self.serializer_class(sso_configuration_record.first())

enterprise/models.py

@@ -4082,7 +4082,8 @@ def submit_for_configuration(self, updating_existing_record=False):
         config_data = {}
         if self.identity_provider == self.SAP_SUCCESS_FACTORS:
             for field in self.sap_config_fields:
-                sap_data[utils.camelCase(field)] = getattr(self, field)
+                if field_value := getattr(self, field):
+                    sap_data[utils.camelCase(field)] = field_value
             is_sap = True
         else:
             for field in self.base_saml_config_fields:
@@ -4091,8 +4092,8 @@ def submit_for_configuration(self, updating_existing_record=False):
                         config_data['enable'] = True
                     else:
                         config_data['enable'] = getattr(self, field)
-                else:
-                    config_data[utils.camelCase(field)] = getattr(self, field)
+                elif field_value := getattr(self, field):
+                    config_data[utils.camelCase(field)] = field_value
 
         EnterpriseSSOOrchestratorApiClient().configure_sso_orchestration_record(
             config_data=config_data,